1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 19:02:41 +01:00
phorge-phorge/src/applications/diffusion/controller/browse/DiffusionBrowseController.php
epriestley 20bcb9379e Phabricator Diffusion: handle missing path errors in browse view
Summary:
When the user gets a path wrong, show them a helpful error message, as
in Diffusion/Confusion.

Test Plan:
Browsed some nonexistent and previously-deleted paths.

Reviewed By: aran
Reviewers: aran, jwilson
CC: aran
Differential Revision: 59
2011-03-07 22:03:23 -08:00

108 lines
3.2 KiB
PHP

<?php
/*
* Copyright 2011 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
class DiffusionBrowseController extends DiffusionController {
private $callsign;
private $path;
private $line;
private $commit;
private $repository;
public function willProcessRequest(array $data) {
$this->callsign = $data['callsign'];
$this->path = rtrim($data['path'], '/');
$this->line = idx($data, 'line');
$this->commit = idx($data, 'commit');
}
public function processRequest() {
$repository = $this->loadRepositoryByCallsign($this->callsign);
$browse_data = DiffusionBrowseQuery::newFromRepository(
$repository,
$this->path,
$this->commit);
$results = $browse_data->loadPaths();
$content = array();
if (!$results) {
switch ($browse_data->getReasonForEmptyResultSet()) {
case DiffusionBrowseQuery::REASON_IS_NONEXISTENT:
$title = 'Path Does Not Exist';
// TODO: Under git, this error message should be more specific. It
// may exist on some other branch.
$body = "This path does not exist anywhere.";
$severity = AphrontErrorView::SEVERITY_ERROR;
break;
case DiffusionBrowseQuery::REASON_IS_DELETED:
// TODO: Format all these commits into nice VCS-agnostic links.
$commit = $this->commit;
$deleted = $browse_data->getDeletedAtCommit();
$existed = $browse_data->getExistedAtCommit();
$title = 'Path Was Deleted';
$body = "This path does not exist at {$commit}. It was deleted in ".
"{$deleted} and last existed at {$existed}.";
$severity = AphrontErrorView::SEVERITY_WARNING;
break;
case DiffusionBrowseQuery::REASON_IS_FILE:
throw new Exception("TODO: implement this");
break;
default:
throw new Exception("Unknown failure reason!");
}
$error_view = new AphrontErrorView();
$error_view->setSeverity($severity);
$error_view->setTitle($title);
$error_view->appendChild('<p>'.$body.'</p>');
$content[] = $error_view;
} else {
$browse_table = new DiffusionBrowseTableView();
$browse_table->setRepository($repository);
$browse_table->setPaths($results);
$browse_table->setRoot($this->path);
$browse_table->setCommit($this->commit);
$browse_panel = new AphrontPanelView();
$browse_panel->setHeader($this->path);
$browse_panel->appendChild($browse_table);
$content[] = $browse_panel;
// TODO: Branch table
}
// TODO: Crumbs
// TODO: Side nav
return $this->buildStandardPageResponse(
$content,
array(
'title' => basename($this->path),
));
}
}