epriestley 2141a28f1b Improve detection of no-op edge edits in ApplicationTransactions ... Summary: Ref T4379. When you add a redundant edge, we currently compare the values strictly, using `===`. However, the old and new versions of the edge have slightly different member data, because one has been synthetically constructed and one has been read from the database. Instead, compare only the things we actually care about: # Were any destintations added or removed? # Was any edge data changed? If the answer to both questions is "no", consider the update a no-op. Test Plan: In the next diff, I'm making project members use the EDGE transaction type. Before this change, adding an existing project member would generate a transaction with no changes. Now, it is correctly detected as a no-op, while normal transactions continue to work properly. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4379 Differential Revision: https://secure.phabricator.com/D8166		2014-02-10 14:29:45 -08:00
..
PhabricatorApplicationTransactionCommentEditor.php	Drafts are saved as inline comments for images when user comments mock	2013-02-07 08:02:52 -08:00
PhabricatorApplicationTransactionEditor.php	Improve detection of no-op edge edits in ApplicationTransactions	2014-02-10 14:29:45 -08:00