epriestley d0c648dfa5 Make "Can Interact" and logged-out users interact more gracefully ... Summary: Fixes T12378. Two minor issues here: - CAN_INTERACT on tasks uses "USER", but should just use the view policy, which may be more permissive ("PUBLIC"). - CAN_INTERACT is currently prevented from being "PUBLIC" by additional safeguards. Define an explicit capability object for the permission which returns `true` from `shouldAllowPublicPolicySetting()`. Test Plan: - Viewed an unlocked task as a logged-out user, saw "login to comment" instead of "locked". - Viewed a locked task as a logged-out user, saw "locked". Reviewers: chad Reviewed By: chad Maniphest Tasks: T12378 Differential Revision: https://secure.phabricator.com/D17485		2017-03-09 08:50:57 -08:00
..
__tests__	Remove empty implementations of describeAutomaticCapabilities()	2016-11-09 15:24:22 -08:00
application	Allow different policy rules for different types of objects	2015-06-13 15:44:03 -07:00
capability	Make "Can Interact" and logged-out users interact more gracefully	2017-03-09 08:50:57 -08:00
codex	Require several advanced postgraduate degrees to understand object policies	2016-11-09 15:05:38 -08:00
config	Move FontIcon calls to Icon	2016-01-28 08:48:45 -08:00
constants	Extend from Phobject	2015-06-15 18:02:27 +10:00
controller	Fix errors found by PHPStan	2017-02-17 10:10:15 +00:00
editor	Fix an issue with editing pre-space objects using a form with no visibility controls	2016-02-18 11:15:40 -08:00
engineextension	Allow *.search Conduit API methods to have data bulk-loaded by extensions	2016-07-31 11:15:18 -07:00
exception	Modernize OAuthserver and provide more context on "no permission" exception	2015-09-03 10:05:23 -07:00
filter	Allow task statuses to "lock" them, preventing additional comments and interactions	2017-03-02 16:57:10 -08:00
interface	Require several advanced postgraduate degrees to understand object policies	2016-11-09 15:05:38 -08:00
management	phtize all the things	2015-05-22 21:16:39 +10:00
phid	Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract	2015-11-03 06:47:12 +11:00
query	Modernize "favorite project policies" setting	2016-06-04 14:42:11 -07:00
rule	Fix flaky subscribers policy rule unit test	2016-12-11 12:27:57 -08:00
storage	Remove empty implementations of describeAutomaticCapabilities()	2016-11-09 15:24:22 -08:00
view	Require several advanced postgraduate degrees to understand object policies	2016-11-09 15:05:38 -08:00