1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/webroot/rsrc/css/application
epriestley 4310c4ed53 Track a "Done" state on inline comments
Summary:
Ref T1460. This just barely works, but throwing it up in case any of it sounds mechanically crazy before we build integrations/UI/etc.

Specifically, these are the behaviors:

  - You can mark your own draft comments as "done" before you submit them. The intent is to let reviewers mark their stuff advisory/minor/not-important before they submit it, to hint to authors that they don't expect the feedback to necessarily be addressed (maybe it's a joke, maybe it's just discussion, maybe it's "consider..").
  - You can mark others' published comments as "done" if you're the revision/commit author. The intent is to keep this lightweight by not requiring an audit trail of who marked what done when. If anyone could mark anything done, we'd have to have some way to show who marked stuff.
  - When you mark stuff done (or unmark it), it goes into a "draft" state, where you see the change but others don't see it yet. The intent is twofold:
    - Be consistent with how inlines work.
    - Allow us to publish a "epriestley updated this revision + epriestley marked 15 inlines as done" story later if we want. This seems more useful than publishing 15 "epriestley marked one thing as done" stories.
  - The actual bit where done-ness publishes isn't implemented.
  - UI is bare bones.
  - No integration with the rest of the UI yet.

Test Plan: Clicked some checkboxes.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: paulshen, chasemp, epriestley

Maniphest Tasks: T1460

Differential Revision: https://secure.phabricator.com/D12033
2015-03-24 05:26:11 -07:00
..
almanac Allow Almanac service types to define default properties 2014-12-17 11:10:50 -08:00
auth Clean up external accounts page 2013-11-24 19:14:16 -08:00
base Hide footer on mobile app switcher 2015-03-23 09:56:39 -07:00
chatlog Make chatlog bg white 2014-02-12 09:55:53 -08:00
config New Admin Welcome Screen 2015-03-02 15:42:25 -08:00
conpherence Update Conpherence full for common colors / styles 2015-03-17 14:01:45 -07:00
contentsource Move #888 and #999 to $lightgreytext 2013-09-02 08:12:18 -07:00
countdown Move #888 and #999 to $lightgreytext 2013-09-02 08:12:18 -07:00
dashboard Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
diff Update InlineCommentSummary UI 2015-02-09 08:38:51 -08:00
differential Track a "Done" state on inline comments 2015-03-24 05:26:11 -07:00
diffusion Convert Audit comment rendering to standard infrastructure 2014-07-28 15:01:43 -07:00
feed Minor fixes for CSS linter issues 2014-12-30 02:48:26 -08:00
files Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem 2012-12-30 09:30:21 -08:00
flag Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00
harbormaster Hide empty build logs 2014-08-06 10:28:13 +10:00
herald Clean up Multirow Manager UI 2014-11-17 14:06:05 -08:00
home Update stock Homepage to look like Dashboards 2015-01-27 15:30:11 -08:00
maniphest Remove AphrontPanelView 2015-03-06 16:44:18 -08:00
objectselector Update ObjectSelector CSS 2013-11-30 19:47:20 -08:00
owners Move #666 to $greytext in UIColor 2013-09-02 08:08:54 -07:00
paste Minor touchup to Paste Embed UI 2015-02-26 11:09:10 -08:00
people T6856 Make Project Images that match Typeahead choices 2015-01-11 09:40:53 -08:00
phame Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
pholio Update Pholio to use pink instead of indigo 2014-10-21 10:06:10 -07:00
phortune Make it easier to add payment methods for subscription autopay 2015-03-02 13:01:08 -08:00
phrequent UIColor Blues and common color integration 2013-09-02 08:10:47 -07:00
phriction Fix padding issues on Phriction History 2015-02-27 11:26:44 -08:00
policy Clean up Multirow Manager UI 2014-11-17 14:06:05 -08:00
ponder Add objectheaders to new View 2013-09-28 15:55:38 -07:00
profile Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
projects Use standard tag elements instead of "maniphest project tag" to show tags in list views 2014-06-26 08:49:44 -07:00
releeph Use standard UI elements to render pull requests in Releeph 2014-04-18 06:44:45 -07:00
search Convert search results to use PHUIObjectItemView 2015-03-03 07:18:40 -08:00
slowvote Move #888 and #999 to $lightgreytext 2013-09-02 08:12:18 -07:00
tokens Make tokens more accessible to assitive technologies 2014-05-05 10:54:34 -07:00
uiexample Clean up FontAwesome / Timeline CSS 2014-04-22 18:29:14 -07:00