1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 00:10:57 +01:00
phorge-phorge/webroot/rsrc
Bob Trahan 22551d106d diffusion / differential - better handle case where no comment selected
Summary: Right now, if no comment is selected the JS executes and throws an exception. Instead, if nothing is selected just do nothing. Fixes T6107.

Test Plan: opened up a commit in diffusion with an inline comment. pressed 'r' and saw no exceptions and nothing happen. pressed 'n' to select the next inline comment and then 'r' and it worked. opened up a commit in diffusion without any inline comments. pressed 'r' and saw no exceptions and nothing happen. opened up a diff in differential with an inline comment. pressed 'r' and saw no exceptons and nothing happened. pressed 'n' to select the next inline comment and then 'r' and it worked.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6107

Differential Revision: https://secure.phabricator.com/D10843
2014-11-12 12:26:22 -08:00
..
css Minor, style multiple blockquote levels in Remarkup 2014-11-11 09:55:06 -08:00
externals Update to FontAwesome 4.2.0 2014-11-03 12:58:02 -08:00
favicons Add HiDPI favicons 2014-11-07 17:07:38 -08:00
image Add HiDPI favicons 2014-11-07 17:07:38 -08:00
js diffusion / differential - better handle case where no comment selected 2014-11-12 12:26:22 -08:00
swf React to Aphlict disconnects in the UI 2014-06-24 09:41:40 -07:00