1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/src
epriestley 22b075df97 Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
Summary: Ref T13404. This query is invalid under "sql_mode=ONLY_FULL_GROUP_BY". Rewrite it to avoid interacting with `actorIdentity` at all; this is a little more robust in the presence of weird data and not really more complicated.

Test Plan:
  - Enabled "ONLY_FULL_GROUP_BY".
  - Hit system actions (e.g., login).
    - Before: error.
    - After: clean login.
  - Tried to login with a bad password many times in a row, got properly limited by the system action rate limiter.

Maniphest Tasks: T13404

Differential Revision: https://secure.phabricator.com/D20782
2019-09-03 16:50:33 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Make minor flavor updates 2019-08-23 07:08:09 -07:00
applications Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries 2019-09-03 16:50:33 -07:00
docs Remove "bin/accountadmin" and "scripts/user/add_user.php" 2019-08-20 17:58:20 -07:00
extensions
infrastructure Use the "@" operator to silence connection retry messages if initializing the stack with database config optional 2019-09-03 12:54:17 -07:00
view Update Phortune payment account interfaces to handle merchant vs customer views 2019-08-22 21:02:41 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Allow repository service lookups to return an ordered list of service refs 2019-09-03 10:05:40 -07:00