1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
phorge-phorge/src/applications/differential/storage
epriestley 54154e4f48 Move "Rendering References" to the DifferentialChangesetParser level
Summary:
Separates changeset IDs from rendering. Now each changeset has a "rendering
reference" which is basically a description of what the ajax endpoint should
render. For Differential, it's in the form "id/vs". For Diffusion,
"branch/path;commit".

I believe this fixes pretty much all of the bugs related to "show more" breaking
in various obscure ways, although I never got a great repro for T153.

Test Plan:
Clicked "show more" in diffusion change and commit views and differential diff,
diff-of-diff, standalone-diff, standalone-diff-of-diff views. Verified refs and
'whitespace' were always sent correctly.

Made inline comments on diffs and diffs-of-diffs. Used "Reply".

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, tuomaspelkonen, epriestley
Differential Revision: 274
2011-05-13 06:10:57 -07:00
..
base Conduit: differential.creatediff 2011-01-24 11:28:12 -08:00
changeset Move "Rendering References" to the DifferentialChangesetParser level 2011-05-13 06:10:57 -07:00
comment Get rid of +x on a bunch of nonexecutable files because I failed to set 2011-04-02 16:47:20 -07:00
diff Sync up UUIDs and create project configs. 2011-04-05 21:55:04 -07:00
diffproperty Lint and unit star support. 2011-04-10 17:19:01 -07:00
hunk Conduit: differential.creatediff 2011-01-24 11:28:12 -08:00
inlinecomment Add some comment caching stuff. 2011-02-02 16:36:53 -08:00
revision Support email replies in Phabricator 2011-05-05 14:58:57 -07:00
viewtime Differential Updates View 2011-04-28 14:40:41 -07:00