epriestley 1308a5555f Update client logic for inline comment "Save" and "Cancel" actions ... Summary: Ref T13559. Substantially correct the client logic for "Save" and "Cancel" actions to handle unusual cases. Test Plan: Quoting behavior: - Quoted a comment. - Cancelled the quoted comment without modifying anything. - Reloaded page. - Before changes: quoted comment still exists. - After changes: quoted comment is deleted. - Looked at comment count in header, saw consistent behavior (before: weird behavior). Empty suggestion behavior: - Created a new comment on a suggestable file. - Clicked "Suggest Edit" to enable suggestions. - Without making any text or suggestion changes, clicked "Save". - Before changes: comment saves, but is empty. - After changes: comment deletes itself without undo. General behavior: - Created and saved an empty comment (deletes itself). - Created and saved a nonempty comment (saves as draft). - Created and saved an empty comment with an edit suggestion (saves). - Created and saved an empty comment with a suggestion to entirely delete lines -- that is, no suggestion text (saves). - Edited a comment, saved without changes (save). - Edited a comment, save deleting all text (saves -- note that this is intentionally without undo, since this is a lot of steps to do by accident). - Cancel editing an unchanged comment (cancels without undo). - Cancel editing a changed comment (cancels with undo). - Undo'd, got text back. - Cancel new comment with no text (deletes without undo). - Cancel new comment with text (deletes with undo). - Undo'd, got text back. - Saved a quoted comment with no changes (saves -- note that this is intentionally not a "delete", since just quoting someone seems fine if you click "Save" -- maybe you want to come back to it later). Maniphest Tasks: T13559 Differential Revision: https://secure.phabricator.com/D21654		2021-03-29 09:00:27 -07:00
..
DiffChangeset.js	Fix an issue where inlines could be duplicated in the client list	2021-03-29 09:00:23 -07:00
DiffChangesetList.js	Make "Open in Editor" use the simple line number of the current selected block	2020-05-21 15:31:16 -07:00
DiffInline.js	Update client logic for inline comment "Save" and "Cancel" actions	2021-03-29 09:00:27 -07:00
DiffInlineContentState.js	Update client logic for inline comment "Save" and "Cancel" actions	2021-03-29 09:00:27 -07:00
DiffPathView.js	Make "hidden" changesets sticky, and show hidden state in the filetree	2020-04-22 16:12:42 -07:00
DiffTreeView.js	Mark "low importance" and "owned" changes in the filetree	2020-04-22 11:22:34 -07:00