1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src
epriestley 241cfc2e83 Don't leave temporary files around when trying to use credentials with destroyed secrets
Summary: Ref T4284. This fixes at least one problem which can cause the observed behavior.

Test Plan:
  - Before applying patch, used `PHABRICATOR_CREDENTIAL=PHID-CDTL-... bin/ssh-connect` + debugging prints to verify the keyfile was written and cleaned up normally.
  - Destroyed the credental, verified the temporary file was not cleand up correctly.
  - Applied patch, verified temporary file was not written and command exited with sensible error.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4284

Differential Revision: https://secure.phabricator.com/D10328
2014-08-21 11:26:02 -07:00
..
__tests__ Rename AphrontQueryException subclasses 2014-08-06 07:51:21 +10:00
aphront Fix security.require-https by marking redirect as external 2014-08-21 21:35:29 +10:00
applications Don't leave temporary files around when trying to use credentials with destroyed secrets 2014-08-21 11:26:02 -07:00
docs Remarkup - add a regex to blacklist what objects get link 2014-08-14 15:20:45 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Be more strict about "Location:" redirects 2014-08-18 14:11:06 -07:00
view Modernize DatePicker 2014-08-16 14:55:22 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php When destroying an object, destroy its Herald transcripts too 2014-08-20 15:04:34 -07:00