mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-23 02:38:48 +02:00
a4e5780043
Summary: Ref T4103. This removes these options: {F1660585} The jump nav option came from T916, when we had a separate jump nav on the home page. Essentially no one has ever been confused by the behavior of search or disabled this feature. Here are the stats for this install: | Total Users | 36656 | | Have Set Any Preference | 3084 | | Have Disabled Jump | 6 | Are Not "Security Researchers" | 2 | Any Account Activity | 0 The "/" option came in the same change, but the preference came from T989. This keystroke conflicts with a default Firefox keystroke. Almost no one cares about this either, but I count 6 real users who have disabled the behavior. I suspect the number of real users who //use// it may be smaller. In Safari and Firefox, the "tab" key does the same thing. In Chrome, the "tab" key does the same thing if {nav Preferences > Web Content > "Pressing Tab highlights..."} is disabled. Upshot: jump nav is great, bulk of the change in T989 was clearly great, specific preferences that came out of it seem not-so-great and now is a good time to kill them as we head into T4103. Test Plan: - Grepped for removed constants. - Pressed "/". - Searched for `T123`. - Viewed settings. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4103 Differential Revision: https://secure.phabricator.com/D15976 |
||
---|---|---|
.. | ||
behavior-active-nav.js | ||
behavior-audio-source.js | ||
behavior-autofocus.js | ||
behavior-badge-view.js | ||
behavior-choose-control.js | ||
behavior-crop.js | ||
behavior-dark-console.js | ||
behavior-detect-timezone.js | ||
behavior-device.js | ||
behavior-drag-and-drop-textarea.js | ||
behavior-error-log.js | ||
behavior-fancy-datepicker.js | ||
behavior-file-tree.js | ||
behavior-form.js | ||
behavior-gesture.js | ||
behavior-global-drag-and-drop.js | ||
behavior-high-security-warning.js | ||
behavior-history-install.js | ||
behavior-hovercard.js | ||
behavior-keyboard-pager.js | ||
behavior-keyboard-shortcuts.js | ||
behavior-lightbox-attachments.js | ||
behavior-line-linker.js | ||
behavior-more.js | ||
behavior-object-selector.js | ||
behavior-oncopy.js | ||
behavior-phabricator-nav.js | ||
behavior-phabricator-remarkup-assist.js | ||
behavior-read-only-warning.js | ||
behavior-refresh-csrf.js | ||
behavior-remarkup-preview.js | ||
behavior-reorder-applications.js | ||
behavior-reveal-content.js | ||
behavior-scrollbar.js | ||
behavior-search-typeahead.js | ||
behavior-select-content.js | ||
behavior-select-on-click.js | ||
behavior-time-typeahead.js | ||
behavior-toggle-class.js | ||
behavior-tokenizer.js | ||
behavior-tooltip.js | ||
behavior-watch-anchor.js | ||
behavior-workflow.js | ||
Busy.js | ||
DragAndDropFileUpload.js | ||
DraggableList.js | ||
FileUpload.js | ||
Hovercard.js | ||
KeyboardShortcut.js | ||
KeyboardShortcutManager.js | ||
MultirowRowManager.js | ||
Notification.js | ||
phtize.js | ||
Prefab.js | ||
ShapedRequest.js | ||
TextAreaUtils.js | ||
Title.js | ||
ToolTip.js |