epriestley 2547a222d8 Guarantee that fields copied from diffs persist on revisions ... Summary: Fixes T4636. Currently, we copy fields from the diff to the revision during the external effect phase, but there's no guarantee that we persist the object after this phase. (In practice, when Herald rules trigger they cause the object to persist on this install, which is why we don't see this issue.) Instead, move the field copies to the internal phase, where persistence is guaranteed. Also consolidate some of the diff loading. Test Plan: Ran `arc diff`. Reviewers: btrahan Reviewed By: btrahan Subscribers: mbishopim3, epriestley Maniphest Tasks: T4636 Differential Revision: https://secure.phabricator.com/D8610		2014-03-25 14:01:38 -07:00
..
aphront	Modernize documentation links	2014-03-17 15:01:31 -07:00
applications	Guarantee that fields copied from diffs persist on revisions	2014-03-25 14:01:38 -07:00
docs	Make install documentation more clear about Windows support	2014-03-16 13:00:20 -07:00
extensions	Add src/extensions/ to Phabricator	2013-08-14 15:38:06 -07:00
infrastructure	Fix typo	2014-03-19 05:13:30 -07:00
view	Make dialogs a little easier to use	2014-03-21 14:40:05 -07:00
__phutil_library_init__.php	Delete license headers from files	2012-11-05 11:16:51 -08:00
__phutil_library_map__.php	Make the "NOTE:" text bold and slightly darker	2014-03-22 18:06:46 -07:00