mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
101 lines
2.4 KiB
PHP
101 lines
2.4 KiB
PHP
<?php
|
|
|
|
final class DifferentialFindConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.find';
|
|
}
|
|
|
|
public function getMethodStatus() {
|
|
return self::METHOD_STATUS_DEPRECATED;
|
|
}
|
|
|
|
public function getMethodStatusDescription() {
|
|
return "Replaced by 'differential.query'.";
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return 'Query Differential revisions which match certain criteria.';
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
$types = array(
|
|
'open',
|
|
'committable',
|
|
'revision-ids',
|
|
'phids',
|
|
);
|
|
|
|
return array(
|
|
'query' => 'required '.$this->formatStringConstants($types),
|
|
'guids' => 'required nonempty list<guids>',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'nonempty list<dict>';
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$type = $request->getValue('query');
|
|
$guids = $request->getValue('guids');
|
|
|
|
$results = array();
|
|
if (!$guids) {
|
|
return $results;
|
|
}
|
|
|
|
$query = id(new DifferentialRevisionQuery())
|
|
->setViewer($request->getUser());
|
|
|
|
switch ($type) {
|
|
case 'open':
|
|
$query
|
|
->withStatus(DifferentialRevisionQuery::STATUS_OPEN)
|
|
->withAuthors($guids);
|
|
break;
|
|
case 'committable':
|
|
$query
|
|
->withStatus(DifferentialRevisionQuery::STATUS_ACCEPTED)
|
|
->withAuthors($guids);
|
|
break;
|
|
case 'revision-ids':
|
|
$query
|
|
->withIDs($guids);
|
|
break;
|
|
case 'owned':
|
|
$query->withAuthors($guids);
|
|
break;
|
|
case 'phids':
|
|
$query
|
|
->withPHIDs($guids);
|
|
break;
|
|
}
|
|
|
|
$revisions = $query->execute();
|
|
|
|
foreach ($revisions as $revision) {
|
|
$diff = $revision->loadActiveDiff();
|
|
if (!$diff) {
|
|
continue;
|
|
}
|
|
$id = $revision->getID();
|
|
$results[] = array(
|
|
'id' => $id,
|
|
'phid' => $revision->getPHID(),
|
|
'name' => $revision->getTitle(),
|
|
'uri' => PhabricatorEnv::getProductionURI('/D'.$id),
|
|
'dateCreated' => $revision->getDateCreated(),
|
|
'authorPHID' => $revision->getAuthorPHID(),
|
|
'statusName' =>
|
|
ArcanistDifferentialRevisionStatus::getNameForRevisionStatus(
|
|
$revision->getStatus()),
|
|
'sourcePath' => $diff->getSourcePath(),
|
|
);
|
|
}
|
|
|
|
return $results;
|
|
}
|
|
|
|
}
|