mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
103 lines
2.8 KiB
PHP
103 lines
2.8 KiB
PHP
<?php
|
|
|
|
final class DifferentialGetRevisionConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.getrevision';
|
|
}
|
|
|
|
public function getMethodStatus() {
|
|
return self::METHOD_STATUS_DEPRECATED;
|
|
}
|
|
|
|
public function getMethodStatusDescription() {
|
|
return "Replaced by 'differential.query'.";
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return 'Load the content of a revision from Differential.';
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'revision_id' => 'required id',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'nonempty dict';
|
|
}
|
|
|
|
protected function defineErrorTypes() {
|
|
return array(
|
|
'ERR_BAD_REVISION' => 'No such revision exists.',
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$diff = null;
|
|
|
|
$revision_id = $request->getValue('revision_id');
|
|
$revision = id(new DifferentialRevisionQuery())
|
|
->withIDs(array($revision_id))
|
|
->setViewer($request->getUser())
|
|
->needRelationships(true)
|
|
->needReviewerStatus(true)
|
|
->executeOne();
|
|
|
|
if (!$revision) {
|
|
throw new ConduitException('ERR_BAD_REVISION');
|
|
}
|
|
|
|
$reviewer_phids = array_values($revision->getReviewers());
|
|
|
|
$diffs = id(new DifferentialDiffQuery())
|
|
->setViewer($request->getUser())
|
|
->withRevisionIDs(array($revision_id))
|
|
->needChangesets(true)
|
|
->needArcanistProjects(true)
|
|
->execute();
|
|
$diff_dicts = mpull($diffs, 'getDiffDict');
|
|
|
|
$commit_dicts = array();
|
|
$commit_phids = $revision->loadCommitPHIDs();
|
|
$handles = id(new PhabricatorHandleQuery())
|
|
->setViewer($request->getUser())
|
|
->withPHIDs($commit_phids)
|
|
->execute();
|
|
|
|
foreach ($commit_phids as $commit_phid) {
|
|
$commit_dicts[] = array(
|
|
'fullname' => $handles[$commit_phid]->getFullName(),
|
|
'dateCommitted' => $handles[$commit_phid]->getTimestamp(),
|
|
);
|
|
}
|
|
|
|
$field_data = $this->loadCustomFieldsForRevisions(
|
|
$request->getUser(),
|
|
array($revision));
|
|
|
|
$dict = array(
|
|
'id' => $revision->getID(),
|
|
'phid' => $revision->getPHID(),
|
|
'authorPHID' => $revision->getAuthorPHID(),
|
|
'uri' => PhabricatorEnv::getURI('/D'.$revision->getID()),
|
|
'title' => $revision->getTitle(),
|
|
'status' => $revision->getStatus(),
|
|
'statusName' =>
|
|
ArcanistDifferentialRevisionStatus::getNameForRevisionStatus(
|
|
$revision->getStatus()),
|
|
'summary' => $revision->getSummary(),
|
|
'testPlan' => $revision->getTestPlan(),
|
|
'lineCount' => $revision->getLineCount(),
|
|
'reviewerPHIDs' => $reviewer_phids,
|
|
'diffs' => $diff_dicts,
|
|
'commits' => $commit_dicts,
|
|
'auxiliary' => idx($field_data, $revision->getPHID(), array()),
|
|
);
|
|
|
|
return $dict;
|
|
}
|
|
|
|
}
|