1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 19:32:40 +01:00
phorge-phorge/src/applications/herald/controller
epriestley 15b41f5639 Remove Herald rule edit log
Summary:
Fixes T7601. Ref T7803, weakly (this removes a Query subclass with ad-hoc paging). Herald has a very old edit log which predates transactions and is essentially useless and not really policy-aware. I think it's doing more harm than good; remove it.

Herald rules have proper transactions, but rule edits don't currently render something nice into the transaction log. This is definitely the way forward, but we haven't seen requests for this so don't bother building it for now.

I did put a nice end-cap on the transaction log, though.

Test Plan:
  - Viewed Herald UI.
  - Grepped for removed classes and methods.
  - Edited a rule.
  - Viewed rule transaction log.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: cburroughs, chad, epriestley

Maniphest Tasks: T7601, T7803

Differential Revision: https://secure.phabricator.com/D12346
2015-04-11 08:50:50 -07:00
..
HeraldController.php Remove Herald rule edit log 2015-04-11 08:50:50 -07:00
HeraldDisableController.php Normalize 'Archived' states in object headers 2015-01-06 11:13:04 -08:00
HeraldNewController.php Rename policy capabilities 2014-07-25 08:20:39 +10:00
HeraldRuleController.php Remove Herald rule edit log 2015-04-11 08:50:50 -07:00
HeraldRuleListController.php Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
HeraldRuleViewController.php Remove Herald rule edit log 2015-04-11 08:50:50 -07:00
HeraldTestConsoleController.php T4666, Support Herald in Phriction 2014-11-11 18:29:36 -08:00
HeraldTranscriptController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
HeraldTranscriptListController.php Fix method visibility for PhabricatorController subclasses 2015-01-07 07:34:59 +11:00