1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 19:02:41 +01:00
phorge-phorge/src/applications/conpherence/controller
Bob Trahan 26f7b69ab2 Conpherence - fix a fatal
Summary:
Ref T7795.

I can't get this to reproduce and its confusing to me how its possible. The trace in T7795 uses the "LOAD" pathway on the update controller. Under the hood, this issues a ThreadQuery with needTransactions to true. With needTransactions to true, the transactions and pertinent handles are all loaded nicely.

So... best guess is there has been some LIMIT of transactions since the offending person participated...? Alternative fix which would probably work is to specify needParticipantCache to true.

More on T7795 - the user report found the "a, b, c..." subtitle thing in the messages dropdown confusing. Yet another fix here would be to change that to be something like "a: snippet of what a said...". I'll discuss that on the task.

Test Plan: iiam

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: nevogd, Korvin, epriestley

Maniphest Tasks: T7795

Differential Revision: https://secure.phabricator.com/D12336
2015-04-10 09:08:38 -07:00
..
ConpherenceColumnViewController.php Conpherence - fix possible fatal 2015-03-31 14:13:41 -07:00
ConpherenceController.php Conpherence - refine menu interactions with respect to "Show More" 2015-03-31 12:45:32 -07:00
ConpherenceListController.php Fix some odd looking arrays 2015-04-05 22:29:39 +10:00
ConpherenceNewController.php Convert all tokenizers to take token/scalar inputs 2015-03-31 14:10:55 -07:00
ConpherenceNewRoomController.php Conpherence - add application search in a few more places. 2015-03-30 16:25:24 -07:00
ConpherenceNotificationPanelController.php Conpherence - unit tests for T7670 2015-03-26 16:46:47 -07:00
ConpherenceRoomListController.php Conpherence - add application search in a few more places. 2015-03-30 16:25:24 -07:00
ConpherenceUpdateController.php Conpherence - fix a fatal 2015-04-10 09:08:38 -07:00
ConpherenceViewController.php Conpherence - refine menu interactions with respect to "Show More" 2015-03-31 12:45:32 -07:00
ConpherenceWidgetController.php Conpherence - implement join / view rules for rooms 2015-03-24 18:38:16 -07:00