1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 20:52:43 +01:00
phorge-phorge/src/applications/herald/adapter
epriestley 0a069cb55a Require a viewer to load handles
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
HeraldCommitAdapter.php Fix Herald "any changed content" rule for commits 2013-01-21 07:46:03 -08:00
HeraldDifferentialRevisionAdapter.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HeraldDryRunAdapter.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HeraldObjectAdapter.php Require a viewer to load handles 2013-02-28 17:15:09 -08:00