mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-18 19:40:55 +01:00
12e6106a59
Summary: See PHI190. This clarifies the ruleset a bit: - If you accepted, then the author used "Request Review" explicitly, we now show "Accepted Earlier" instead of "Accepted" in the "Reviewers" list on the main revision page. This makes it sligthly more clear why the revision is back in your review queue without picking through the transaction log. - Instead of moving all non-current accepts into "Ready to Review", move only voided accepts into "Ready to Review". This stops us from pulling older accepts which haven't been voided (which could have been incorrectly pulled) and correctly pulls older, voided accepts from before an update (for example: accept, then request review, then update) and generally aligns better with intent/expectation. Test Plan: - Accepted, requested review. - Saw reviewer as "Accepted Earlier". - Saw review in "Ready to Review" bucket. - Accepted, updated (with sticky accept). - Saw reviewer as "Accepted Prior Diff". - Saw review as "Waiting on Authors". Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18764 |
||
|---|---|---|
| .. | ||
| DifferentialChangesetQuery.php | ||
| DifferentialDiffInlineCommentQuery.php | ||
| DifferentialDiffQuery.php | ||
| DifferentialDiffSearchEngine.php | ||
| DifferentialDiffTransactionQuery.php | ||
| DifferentialHunkQuery.php | ||
| DifferentialInlineCommentQuery.php | ||
| DifferentialRepositoryLookup.php | ||
| DifferentialRevisionQuery.php | ||
| DifferentialRevisionRequiredActionResultBucket.php | ||
| DifferentialRevisionResultBucket.php | ||
| DifferentialRevisionSearchEngine.php | ||
| DifferentialTransactionQuery.php | ||