1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src/applications/drydock
epriestley f3f1f9dc57 Allow "drydock.blueprint.edit" to create blueprints
Summary:
Depends on D18848. Ref PHI243. This puts a bit of logic up front to figure out the blueprint type before we actually start editing it.

This implementation is a little messy but it keeps the API clean. Eventually, the implementation could probably go in the TransactionTypes so more code is shared, but I'd like to wait for a couple more of these first.

This capability probably isn't too useful, but just pays down a bit of technical debt from the caveat introduced in D18822.

Test Plan:
  - Created a new blueprint with the API.
  - Tried to create a blueprint without a "type" (got a helpful error).
  - Created and edited blueprints via the web UI.
  - Tried to change the "type" of an existing blueprint (got a helpful error).

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D18849
2018-01-04 10:08:07 -08:00
..
application Unprototype Drydock 2016-03-04 17:23:07 -08:00
blueprint Fix spelling 2017-10-09 10:48:04 -07:00
capability Give Drydock resources a proper expiry mechanism 2015-09-28 09:35:14 -07:00
conduit Allow "drydock.blueprint.edit" to create blueprints 2018-01-04 10:08:07 -08:00
constants Modernize Drydock SearchEngine implementations 2015-09-24 09:56:49 -07:00
controller Modularize transactions for Drydock Blueprints 2018-01-04 10:03:44 -08:00
customfield Convert DrydockBlueprints to EditEngine 2016-03-03 15:21:25 -08:00
editor Allow "drydock.blueprint.edit" to create blueprints 2018-01-04 10:08:07 -08:00
exception Improve Drydock errors for empty commits and missing changes 2016-03-07 05:29:25 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
interface Make WorkingCopyBlueprint responsible for performing merges 2015-10-26 12:40:16 -07:00
logtype Make Drydock reclaim unused resources when it reaches a resource limit 2015-12-18 11:55:51 -08:00
management Fix 4 typos in code 2017-04-07 04:09:56 -07:00
operation Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Expose Drydock authorizations via Conduit 2016-10-11 19:55:43 +00:00
storage Modularize transactions for Drydock Blueprints 2018-01-04 10:03:44 -08:00
typeahead Render browse results with global result style 2016-06-20 16:49:02 -07:00
view Convert Drydock to two column layout 2016-03-13 08:10:36 -07:00
worker Fix spelling 2017-10-09 10:48:04 -07:00
xaction Allow "drydock.blueprint.edit" to create blueprints 2018-01-04 10:08:07 -08:00