revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 29957d196b Fix some more setIcon() issues 
Summary: Fixes T11569. This fixes a known bad `setIcon()`. I also looked for more calls to `setIcon()` without success, and stubbed `setIcon()` so we're in good shape even if more exist.

Test Plan:
  - Grepped for `setIcon(` and manually inspect all 1,004 callsites to look for calls on `PHUIObjectItemView` objects.
  - Grepped for "high risk" callsites (`setIcon` in file after `PHUIObjectItemView`) and re-examined them. I identified these files with this command:

```
git ls-tree -r --name-only HEAD | xargs pcregrep -i -M -H -c --files-with-matches -o 'PHUIObjectItemView(.|\n)*setIcon'
```

There might be some more clever way to do that.
  - Since this only identified the callsites I already knew about and I don't have a ton of confidence that I didn't miss any, I put a stub in place that logs a deprecation warning. I'll file a followup to go clean these up in a month or so if the logs are clean.
  - Loaded Nuance, saw it work but warn.
  - Changed Nuance to use `setStatusIcon()`, loaded Nuance, no more fatal.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11569

Differential Revision: https://secure.phabricator.com/D16477
2016-08-31 10:00:03 -07:00
..
almanac Fix getIcon calls in PHUIObjectListItem 2016-08-19 09:35:09 -07:00
aphlict Cache user notification and message counts 2016-06-05 08:52:43 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
auth Redesign Config Application 2016-08-29 15:49:49 -07:00
badges Better destruction of PhameBlog, BadgesBadge 2016-06-27 18:24:23 -07:00
base Removed all instances of getIconURI 2016-08-29 18:11:31 -04:00
cache Add --purge-user to bin/cache purge 2016-06-04 14:45:15 -07:00
calendar Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
celerity Update Celerity map parser for new docblock code 2016-08-23 14:49:15 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Add patch to remove conduit_connectionlog table (Fixes T9982) 2016-08-23 03:57:14 -05:00
config Add some icons/color to Config Settings UI 2016-08-30 12:58:15 -07:00
conpherence Generate "stub" events earlier, so more infrastructure works with Calendar 2016-07-13 07:41:16 -07:00
console After toggling DarkConsole, force a user settings cache fill 2016-06-05 10:04:23 -07:00
countdown Fix new Countdown link 2016-06-07 20:13:08 -07:00
daemon Fix a fatal when viewing a daemon task with an invalid ID 2016-07-08 07:08:45 -07:00
dashboard Implement a "pro" EditEngine for dashboard panels 2016-07-03 15:07:36 -07:00
differential Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
diffusion Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
diviner Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Fix getIcon calls in PHUIObjectListItem 2016-08-19 09:35:09 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
files Allow file comments to be edited 2016-07-18 16:17:43 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
guides Move Guides ObjectList styles to PHUIObjectItemListView 2016-08-29 09:27:10 -07:00
harbormaster Redesign Config Application 2016-08-29 15:49:49 -07:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Link Herald rules to rule detail pages in Herald transcripts 2016-08-10 08:53:03 -07:00
home New 'default' homepage 2016-08-25 11:28:37 -07:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Add setup checks for unused homepage options 2016-08-25 12:08:02 -07:00
meta Removed all instances of getIconURI 2016-08-29 18:11:31 -04:00
metamta Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Strip timestamps from popup notification bubbles 2016-07-08 07:46:09 -07:00
nuance Fix some more setIcon() issues 2016-08-31 10:00:03 -07:00
oauthserver Formalize and fully modularize settings panel groups 2016-06-04 14:39:11 -07:00
owners Correct spelling of "therefore" 2016-08-30 14:09:05 -07:00
packages Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
passphrase Prevent locked credentials from being made accessible via conduit 2016-05-18 14:54:44 -07:00
paste Fix the feed line items for autodetect paste languages 2016-08-29 22:29:29 -04:00
people Update People for handleRequest 2016-08-25 13:39:59 -04:00
phame Raise human-readable error messages for overlong Phame blog titles and subtitles 2016-07-21 09:48:06 -07:00
phid Simplify how tag lists manage their handles 2016-08-19 11:09:40 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
phortune Implement PhabricatorApplicationTransactionInterface on PhortunePaymentProviderConfig 2016-08-30 09:18:10 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Redesign Config Application 2016-08-29 15:49:49 -07:00
phriction Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
phurl Start actually showing the phurl urls to users 2016-08-29 22:49:01 -04:00
policy Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
ponder Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
project Use consistent tag order in Maniphest list views and workboard cards 2016-08-03 16:46:40 -07:00
releeph Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Add a summary view of all repository errors to the repository cluster screen 2016-08-30 09:21:12 -07:00
search Fix search results with tables, fatals in Phortune 2016-08-29 20:39:53 -07:00
settings Converted the pinned applications selector to a typeahead. 2016-08-26 14:24:28 -04:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Redesign Config Application 2016-08-29 15:49:49 -07:00
tokens More tokens 2016-07-03 18:32:40 -07:00
transactions Redesign Config Application 2016-08-29 15:49:49 -07:00
typeahead Push typehead browse result selector button down one <div> 2016-06-21 15:28:12 -07:00
uiexample Add setBackground to PHUIIconView 2016-08-19 13:19:53 -07:00
xhprof Removing deprecated method calls 2016-08-23 03:26:34 -05:00