revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/herald
History
Aviv Eyal de6349dd67 Revision substate CLOSED_FROM_ACCEPTED 
Summary:
Ref T9838.

Add a Properties field to Revision, and update a `wasAcceptedBeforeClose` when closing a revision.

Test Plan:
A quick run through the obvious steps (Close with commit/manually,  with or w/o accept) and calling `differential.query` shows the `wasAcceptedBeforeClose` property was setup correctly.

Pushing closed + accepted passes the relevant herald, which was my immediate issue; Pushing un-accepted is blocked.
Test the "commit" rule (Different from "pre-commit") by hacking the DB and running the "has accepted revision" rule in a test-console.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T9838

Differential Revision: https://secure.phabricator.com/D15085
2016-06-27 20:29:47 +00:00
..
DiffusionAuditorsAddAuditorsHeraldAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
DiffusionAuditorsAddSelfHeraldAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
DiffusionAuditorsHeraldAction.php Improve audit behavior for "uninteresting" auditors 2016-05-17 13:47:33 -07:00
DiffusionBlockHeraldAction.php Fix some copy/paste slop with BLOCK actions in Herald transcripts 2015-08-04 07:32:19 -07:00
DiffusionChangeHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitAutocloseHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitBranchesHeraldField.php Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
DiffusionCommitCommitterHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffEnormousHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitMergeHeraldField.php Add "Is merge commit?" to commit fields in Herald 2015-12-05 13:07:56 -08:00
DiffusionCommitMessageHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionCommitPackageAuditHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitPackageHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitPackageOwnerHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitReviewerHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitRevisionAcceptedHeraldField.php Revision substate CLOSED_FROM_ACCEPTED 2016-06-27 20:29:47 +00:00
DiffusionCommitRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRevisionReviewersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRevisionSubscribersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentAuthorRawHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentBranchesHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentCommitterHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentCommitterRawHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffEnormousHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentMergeHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentMessageHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentPusherHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentPusherIsCommitterHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentPusherProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRevisionAcceptedHeraldField.php Revision substate CLOSED_FROM_ACCEPTED 2016-06-27 20:29:47 +00:00
DiffusionPreCommitContentRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentRevisionReviewersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentRevisionSubscribersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefChangeHeraldField.php Further modularize Herald values 2015-07-16 14:12:23 -07:00
DiffusionPreCommitRefHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefNameHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitRefPusherHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefPusherProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefTypeHeraldField.php Further modularize Herald values 2015-07-16 14:12:23 -07:00
HeraldCommitAdapter.php Remove various additional calls to getCallsign() 2016-01-02 11:04:22 -08:00
HeraldPreCommitAdapter.php Modularize the Diffusion/Differential "Block" Herald actions 2015-08-03 14:33:28 -07:00
HeraldPreCommitContentAdapter.php Modularize Herald Diffusion pre-commit content fields 2015-07-08 12:26:57 -07:00
HeraldPreCommitRefAdapter.php Further modularize Herald values 2015-07-16 14:12:23 -07:00