1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/conduit
epriestley 2a5c987c71 Lock policy queries to their applications
Summary:
While we mostly have reasonable effective object accessibility when you lock a user out of an application, it's primarily enforced at the controller level. Users can still, e.g., load the handles of objects they can't actually see. Instead, lock the queries to the applications so that you can, e.g., never load a revision if you don't have access to Differential.

This has several parts:

  - For PolicyAware queries, provide an application class name method.
  - If the query specifies a class name and the user doesn't have permission to use it, fail the entire query unconditionally.
  - For handles, simplify query construction and count all the PHIDs as "restricted" so we get a UI full of "restricted" instead of "unknown" handles.

Test Plan:
  - Added a unit test to verify I got all the class names right.
  - Browsed around, logged in/out as a normal user with public policies on and off.
  - Browsed around, logged in/out as a restricted user with public policies on and off. With restrictions, saw all traces of restricted apps removed or restricted.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7367
2013-10-21 17:20:27 -07:00
..
application Modernize most Conduit console interfaces 2013-07-01 12:36:34 -07:00
call Fix daemon auth issue 2013-10-18 18:29:36 -07:00
config Route internal conduit calls if other hosts available 2013-05-19 04:16:10 -07:00
controller Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
method Require application "Can Use" capability to call Conduit methods 2013-10-17 12:51:19 -07:00
protocol Delete license headers from files 2012-11-05 11:16:51 -08:00
query Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
ssh Mostly modernize Conduit logs 2013-07-01 12:37:34 -07:00
storage Explain policy exception rules to users 2013-09-27 08:43:41 -07:00