mirror of
https://we.phorge.it/source/phorge.git
synced 2025-04-10 11:28:35 +02:00
2a5c987c71
Summary: While we mostly have reasonable effective object accessibility when you lock a user out of an application, it's primarily enforced at the controller level. Users can still, e.g., load the handles of objects they can't actually see. Instead, lock the queries to the applications so that you can, e.g., never load a revision if you don't have access to Differential. This has several parts: - For PolicyAware queries, provide an application class name method. - If the query specifies a class name and the user doesn't have permission to use it, fail the entire query unconditionally. - For handles, simplify query construction and count all the PHIDs as "restricted" so we get a UI full of "restricted" instead of "unknown" handles. Test Plan: - Added a unit test to verify I got all the class names right. - Browsed around, logged in/out as a normal user with public policies on and off. - Browsed around, logged in/out as a restricted user with public policies on and off. With restrictions, saw all traces of restricted apps removed or restricted. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7367
112 lines
2.9 KiB
PHP
112 lines
2.9 KiB
PHP
<?php
|
|
|
|
final class PhabricatorFeedQuery
|
|
extends PhabricatorCursorPagedPolicyAwareQuery {
|
|
|
|
private $filterPHIDs;
|
|
private $chronologicalKeys;
|
|
|
|
public function setFilterPHIDs(array $phids) {
|
|
$this->filterPHIDs = $phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withChronologicalKeys(array $keys) {
|
|
$this->chronologicalKeys = $keys;
|
|
return $this;
|
|
}
|
|
|
|
protected function loadPage() {
|
|
|
|
$story_table = new PhabricatorFeedStoryData();
|
|
$conn = $story_table->establishConnection('r');
|
|
|
|
$data = queryfx_all(
|
|
$conn,
|
|
'SELECT story.* FROM %T story %Q %Q %Q %Q %Q',
|
|
$story_table->getTableName(),
|
|
$this->buildJoinClause($conn),
|
|
$this->buildWhereClause($conn),
|
|
$this->buildGroupClause($conn),
|
|
$this->buildOrderClause($conn),
|
|
$this->buildLimitClause($conn));
|
|
|
|
return $data;
|
|
}
|
|
|
|
protected function willFilterPage(array $data) {
|
|
return PhabricatorFeedStory::loadAllFromRows($data, $this->getViewer());
|
|
}
|
|
|
|
private function buildJoinClause(AphrontDatabaseConnection $conn_r) {
|
|
// NOTE: We perform this join unconditionally (even if we have no filter
|
|
// PHIDs) to omit rows which have no story references. These story data
|
|
// rows are notifications or realtime alerts.
|
|
|
|
$ref_table = new PhabricatorFeedStoryReference();
|
|
return qsprintf(
|
|
$conn_r,
|
|
'JOIN %T ref ON ref.chronologicalKey = story.chronologicalKey',
|
|
$ref_table->getTableName());
|
|
}
|
|
|
|
private function buildWhereClause(AphrontDatabaseConnection $conn_r) {
|
|
$where = array();
|
|
|
|
if ($this->filterPHIDs) {
|
|
$where[] = qsprintf(
|
|
$conn_r,
|
|
'ref.objectPHID IN (%Ls)',
|
|
$this->filterPHIDs);
|
|
}
|
|
|
|
if ($this->chronologicalKeys) {
|
|
// NOTE: We want to use integers in the query so we can take advantage
|
|
// of keys, but can't use %d on 32-bit systems. Make sure all the keys
|
|
// are integers and then format them raw.
|
|
|
|
$keys = $this->chronologicalKeys;
|
|
foreach ($keys as $key) {
|
|
if (!ctype_digit($key)) {
|
|
throw new Exception("Key '{$key}' is not a valid chronological key!");
|
|
}
|
|
}
|
|
|
|
$where[] = qsprintf(
|
|
$conn_r,
|
|
'ref.chronologicalKey IN (%Q)',
|
|
implode(', ', $keys));
|
|
}
|
|
|
|
$where[] = $this->buildPagingClause($conn_r);
|
|
|
|
return $this->formatWhereClause($where);
|
|
}
|
|
|
|
private function buildGroupClause(AphrontDatabaseConnection $conn_r) {
|
|
return qsprintf(
|
|
$conn_r,
|
|
'GROUP BY '.($this->filterPHIDs
|
|
? 'ref.chronologicalKey'
|
|
: 'story.chronologicalKey'));
|
|
}
|
|
|
|
protected function getPagingColumn() {
|
|
return ($this->filterPHIDs
|
|
? 'ref.chronologicalKey'
|
|
: 'story.chronologicalKey');
|
|
}
|
|
|
|
protected function getPagingValue($item) {
|
|
if ($item instanceof PhabricatorFeedStory) {
|
|
return $item->getChronologicalKey();
|
|
}
|
|
return $item['chronologicalKey'];
|
|
}
|
|
|
|
|
|
public function getQueryApplicationClass() {
|
|
return 'PhabricatorApplicationFeed';
|
|
}
|
|
|
|
}
|