1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/people/query
epriestley 2b344b2bb5 Make caches misses throw by default intead of inline-generating
Summary:
Ref T4103. Ref T10078. Currently, when a user misses a cache we just build it for them.

This is the behavior we want for the the viewer (so we don't have to build every cache up front if we don't actually need them), but not the right behavior for other users (since it allows performance problems to go undetected).

Make inline cache generation strict by default, then make sure all the things that rely on cache data request the correct data (well, all of the things identified by unit tests, at least: there might be some more stuff I haven't hit yet).

This fixes test failures in D16040, and backports a piece of that change.

Test Plan: Identified and then fixed failures with `arc unit --everything`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103, T10078

Differential Revision: https://secure.phabricator.com/D16042
2016-06-05 08:51:54 -07:00
..
PhabricatorPeopleLogQuery.php Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery 2015-04-20 10:06:09 -07:00
PhabricatorPeopleLogSearchEngine.php [Redesign] Remove AphrontTable restriction on Search Engine 2015-06-29 12:28:55 -07:00
PhabricatorPeopleQuery.php Make caches misses throw by default intead of inline-generating 2016-06-05 08:51:54 -07:00
PhabricatorPeopleSearchEngine.php Add a modern user.search Conduit API method 2016-05-22 05:54:31 -07:00
PhabricatorPeopleTransactionQuery.php Implement PhabricatorApplicationTransactionInterface on PhabricatorUser 2015-06-08 13:35:57 -07:00