1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 11:30:55 +01:00
phorge-phorge/src/applications/audit
epriestley 1cd3a59378 When users resign from revisions, stop expanding projects/packages to include them
Summary:
Depends on D19019. Ref T13053. Fixes T12689. See PHI178.

Currently, if `@alice` resigns from a revision but `#alice-fan-club` is still a subscriber or reviewer, she'll continue to get mail. This is undesirable.

When users are associated with an object but have explicitly disengaged in an individal role (currently, only resign in audit/differential) mark them "unexpandable", so that they can no longer be included through implicit membership in a group (a project or package).

`@alice` can still get mail if she's a explicit recipient: as an author, owner, or if she adds herself back as a subscriber.

Test Plan:
  - Added `@ducker` and `#users-named-ducker` as reviewers. Ducker got mail.
  - Resigned as ducker, stopped getting future mail.
  - Subscribed explicitly, got mail again.
  - (Plus some `var_dump()` sanity checking in the internals.)

Reviewers: amckinley

Maniphest Tasks: T13053, T12689

Differential Revision: https://secure.phabricator.com/D19021
2018-02-08 06:29:13 -08:00
..
application Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
conduit Remove several pieces of audit-related code 2017-01-30 15:26:26 -08:00
constants Remove several pieces of audit-related code 2017-01-30 15:26:26 -08:00
controller Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
editor When users resign from revisions, stop expanding projects/packages to include them 2018-02-08 06:29:13 -08:00
mail Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
management Make "bin/audit synchronize" actually save changes 2017-01-31 12:23:49 -08:00
query Restrict Audit buckets to just ApplicationSearch views 2017-03-23 12:46:19 -07:00
storage Build a page for viewing all inline comments 2017-06-12 11:31:20 -07:00
view Fix spelling 2017-10-09 10:48:04 -07:00