1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/files
epriestley 7c4c76d32a Fix a Quicksand/Lightbox contention issue
Summary:
Fixes T11785. Lightbox calls `JX.Stratcom.pass()` to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist `/file/data/` from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan:
  - Disabled `security.alternate-file-domain`.
  - Enabled Quicksand ("Persistent Chat").
  - Clicked an image thumbnail on a task.
    - Repeated that until things flipped out a bit.
    - After the patch: no issues.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11785

Differential Revision: https://secure.phabricator.com/D16884
2016-11-16 17:10:56 -08:00
..
action Rate limit outbound requests in Macros 2015-03-26 11:11:52 -07:00
application Fix a Quicksand/Lightbox contention issue 2016-11-16 17:10:56 -08:00
applicationpanel Allow diffusion.filecontentquery to load data for arbitrarily large files 2016-01-21 09:52:43 -08:00
builtin Add a map marker icon for Milestones 2016-02-05 13:40:52 -08:00
capability Add default policy to Files application 2014-11-21 11:17:20 -08:00
conduit Detect the MIME type of large files by examining the first chunk 2016-06-30 13:57:39 -07:00
config Add "video/quicktime" as a default Video MIME type 2016-06-14 14:44:18 -07:00
controller When a file is stored as chunks, show "Format: Chunks" instead of "Format: Raw" 2016-09-29 15:47:09 -07:00
edge Modernize remaining edge types 2015-01-03 10:58:20 +11:00
editor Transactions - make implementing TYPE_XXXX_POLICY transactions optional 2015-05-19 12:58:18 -07:00
engine Add support to Files for file storage formats, to support encryption-at-rest 2016-06-15 11:17:53 -07:00
exception Give users an explicit error if they try to upload a too-large diff to Differential 2016-01-08 18:53:33 -08:00
format Support AES256 at-rest encryption in Files 2016-06-16 08:08:56 -07:00
garbagecollector Endpoint+controller for a remarkup image proxy 2016-09-23 10:28:24 -04:00
iconset Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
keyring Support AES256 at-rest encryption in Files 2016-06-16 08:08:56 -07:00
lipsum Improve bin/lipsum UX 2015-12-24 09:06:35 -08:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
management Add a "--copy" flag to "bin/files migrate" 2016-09-06 13:53:59 -07:00
markup Remarkup rule to embed images 2016-09-26 16:55:38 -04:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Simplify "builtin file" management and recover from races 2016-07-11 09:25:34 -07:00
storage Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
transform Scale up small cover images instead of surrounding them with empty space 2016-02-06 16:09:38 -08:00
uploadsource Support pushing data into Git LFS 2016-03-18 09:36:34 -07:00
view Allow users to drop .ics files on calendar views to import them 2016-10-18 15:26:44 -07:00
PhabricatorImageTransformer.php Extend from Phobject 2015-06-15 18:02:27 +10:00