1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src
epriestley 2c3d071a26 Improve exception behavior for Herald commit rules which fail to load diff context
Summary:
This code is a little funky right now, and can return `array("error message")` and then try to call `getHunks()` on it. Additionally, each field loads the commit's changes separately.

Instead, load the commit's changes once and cache them, and handle exceptions appropriately.

Test Plan:
  - Created a rule like "changed, added, removed content all match /.*/" to force all fields to generate.
  - Ran it successfully.
  - Faked an error and ran it, got reasonable results.

Reviewers: btrahan

Reviewed By: btrahan

CC: bigo, aran

Differential Revision: https://secure.phabricator.com/D7384
2013-10-23 08:28:58 -07:00
..
aphront Tie application event listeners to the applications they listen for 2013-10-21 17:00:21 -07:00
applications Improve exception behavior for Herald commit rules which fail to load diff context 2013-10-23 08:28:58 -07:00
docs Convert maniphest to use standard fields 2013-09-19 11:56:15 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
view Add a secret board view to Projects 2013-10-21 21:11:36 -07:00
__celerity_resource_map__.php Add top border back to section-headers 2013-10-22 08:49:13 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Harbormaster v(-2) 2013-10-22 15:01:06 -07:00