1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 11:12:42 +01:00
phorge-phorge/src/applications/maniphest
epriestley a1ccee8c24 Implicitly subscribe task author when they create a task
Summary:
Ref T9908. This is a behavioral change:

  - Old behavior: "Subscribers" field is default-populated with author.
  - New behavior: this transaction is just created no matter what.

The new behavior is much easier to make work with form defaults, hidden fields, etc. For example, on the "Create Bug" form, I've hidden "Subscribers", but I still want the author to be subscribed.

And if a user sets the default value of "Subscribers:" to "Alice, Bob", they almost certainly mean "Alice, Bob, and the task author".

And I ended up deleting myself by accident way more often than I deleted myself on purpose -- especially with "Create Similar task", I'd sometimes delete all the CCs and delete myself by accident and then have to put myself back.

Finally, technically speaking, restoring the old behavior is kind of hard/messy and this is much easier.

Test Plan:
  - Created a task.
  - Was automatically added as a subscriber.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9908

Differential Revision: https://secure.phabricator.com/D14694
2015-12-07 11:13:58 -08:00
..
__tests__ Drive Maniphest grouping and ordering through standard infrastructure 2015-06-08 12:23:13 -07:00
application Populate the "Quick Create" menu from EditEngine 2015-12-07 11:13:34 -08:00
bulk Fix "Add Project" in bulk editor 2015-07-02 14:24:15 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Allow Maniphest statuses and priorities to be disabled 2015-12-05 11:01:41 -08:00
conduit Rough in EditEngine for Maniphest 2015-12-04 16:29:23 -08:00
config Validate configuration of maniphest.priorities 2015-12-05 17:11:11 -08:00
constants Validate configuration of maniphest.priorities 2015-12-05 17:11:11 -08:00
controller Swap "Create Task" button over to EditEngine 2015-12-04 16:29:41 -08:00
edge Modernize Pholio edges 2015-01-02 10:11:41 +11:00
editor Implicitly subscribe task author when they create a task 2015-12-07 11:13:58 -08:00
event Add Priority to Maniphest Hovercard 2015-07-28 19:42:26 -07:00
export Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
field Add "and" support to "ref" 2015-05-05 07:14:15 +10:00
herald Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
lipsum Fix some linter violations 2015-01-03 09:11:41 +11:00
mail Add Maniphest Task email creator to CCs 2015-09-09 14:07:07 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Allow PolicyRules to serve as "Object Policies" 2015-06-13 15:44:38 -07:00
query Move some PhabricatorSearchField subclasses 2015-07-06 22:52:05 +10:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
search Rename PhabricatorSearchField to PhabricatorSearchFieldDocumentType 2015-06-05 11:01:25 -07:00
storage Fix a translation 2015-11-13 07:04:48 +11:00
typeahead Allow Maniphest statuses and priorities to be disabled 2015-12-05 11:01:41 -08:00
view Various translation improvements 2015-11-03 07:02:46 +11:00