1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-07 12:28:28 +01:00
phorge-phorge/src/applications/config
Katie d4af32c1d4 Fix setup check for gzip request mangling being sent as GET
Summary:
Certain web servers (or cache layers such as Varnish) strip the body
of GET requests, resulting in the setup check failing when it would
otherwise function normally if a request is sent as POST.

Test Plan:
Phorge will no-longer mark the test as failing due to the body of a GET request being dropped.
As per RFC7231, certain implementations of HTTP/1.1 may reject the request or drop the payload
due to a previous revision of the spec where the body was supposed to be ignored (RFC2616, section 4.3)

Reviewers: O1 Blessed Committers, 20after4, speck, avivey

Reviewed By: O1 Blessed Committers, 20after4, speck, avivey

Subscribers: speck, 20after4, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25566
2024-04-02 21:49:00 +03:00
..
application Remove product literal strings in "pht()", part 2 2022-04-25 12:22:26 -07:00
check Fix setup check for gzip request mangling being sent as GET 2024-04-02 21:49:00 +03:00
constants Config re-design 2017-09-05 15:24:15 -07:00
controller Config page: add lovely git-related error messages in standard error log 2023-06-10 13:21:41 +02:00
custom Remove product literal strings in "pht()", part 3 2022-04-25 12:22:26 -07:00
editor Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
engine When we "discover" new fatal setup issues, stop serving traffic 2016-11-21 15:54:40 -08:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
issue Remove product literal strings in "pht()", part 16 2022-04-25 16:46:25 -07:00
json Improve UI formatting of some configuration values 2015-12-05 09:58:47 -08:00
management Allow bin/config to create config file 2019-09-08 00:16:19 +00:00
module Split setup checks into "preflight" and "normal" checks 2016-09-06 11:57:18 -07:00
option Fix typo 2023-12-18 10:50:35 +01:00
phid Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
query Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
response Remove product literal strings in "pht()", part 4 2022-04-25 12:22:27 -07:00
schema Update MySQL schema inspection code for deprecation of integer display widths 2020-05-18 12:10:31 -07:00
storage Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
type Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/" 2019-02-28 07:29:36 -08:00
view Improve command line prompts in setup issue pages 2023-12-07 16:22:24 +00:00