mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 02:12:41 +01:00
dbdb01f858
Summary: Fixes T181. I actually have no idea what the original issue in T181 was, but this fixes several problems: - The code for figuring out whitespace-only changes was extremely confusing and probably buggy (the code for figuring out unchanged files was equally confusing but probably less buggy). - When rendering a whitespace shield, we did not offer a "Show Changes" link. Instead, show the "Show Changes" link: we can always render the content beneath this link. - When clicking "Show Changes", we used the current whitespace mode, which might result in a diff with no changes. Instead, force "show all" whitespace mode. - We never offered a "show changes" link for unchanged files. Instead, offer this link if we can service it. - When clicking "Show Changes", we pierced the shield but didn't force file content, which would fold the entire file even if it was available. Instead, force the file content. Test Plan: Generated whitespace-only and no-change diffs. Clicked shield links, or verified no shield link available in no-change-with-no-content. Generated an "@generated" change, verified shield worked correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T181, T2009 Differential Revision: https://secure.phabricator.com/D4407 |
||
|---|---|---|
| .. | ||
| behavior-accept-with-errors.js | ||
| behavior-add-reviewers-and-ccs.js | ||
| behavior-comment-jump.js | ||
| behavior-comment-preview.js | ||
| behavior-diff-radios.js | ||
| behavior-dropdown-menus.js | ||
| behavior-edit-inline-comments.js | ||
| behavior-keyboard-nav.js | ||
| behavior-populate.js | ||
| behavior-show-all-comments.js | ||
| behavior-show-field-details.js | ||
| behavior-show-more.js | ||
| behavior-toggle-files.js | ||
| behavior-user-select.js | ||
| DifferentialInlineCommentEditor.js | ||