1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 08:06:13 +01:00
phorge-phorge/src/applications/harbormaster/query
epriestley a817aa6c71 Add an "Abort Older Builds" build step to Harbormaster
Summary:
Ref T13124. See PHI531. When a revision is updated, builds against the older diff tend to stop being relevant. Add an option to abort outstanding older builds automatically.

At least for now, I'm adding this as a build step instead of some kind of special checkbox. An alternate implementation would be some kind of "Edit Options" action on plans with a checkbox like `[X] When this build starts, abort older builds.`

I think adding it as a build step is a bit simpler, and likely to lead to greater consistency and flexibility down the road, make it easier to add options, etc., and since we don't really have any other current use cases for "a bunch of checkboxes". This might change eventually if we add a bunch of checkboxes for some other reason.

The actual step activates //before// the build queues, so it doesn't need to wait in queue before it can actually act. T13088 discusses some plans here if this sticks.

Test Plan:
  - Created a "Sleep for 120 seconds" build plan and triggered it with Herald.
  - Added an "Abort Older Builds" step.
  - Updated a revision several times in a row, saw older builds abort.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13124

Differential Revision: https://secure.phabricator.com/D19376
2018-04-17 14:59:47 -07:00
..
HarbormasterBuildableQuery.php Update Buildable search in Harbormaster 2016-02-27 07:13:10 -08:00
HarbormasterBuildableSearchEngine.php Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00
HarbormasterBuildableTransactionQuery.php Remove @group annotations 2014-07-10 08:12:48 +10:00
HarbormasterBuildArtifactQuery.php In Harbormaster, release artifacts as soon as no waiting/running build steps will use them 2016-06-17 16:13:56 -07:00
HarbormasterBuildLogQuery.php Provide API read access to Harbormaster build logs 2018-02-28 12:36:03 -08:00
HarbormasterBuildLogSearchEngine.php Provide API read access to Harbormaster build logs 2018-02-28 12:36:03 -08:00
HarbormasterBuildMessageQuery.php Rename HarbormasterBuildMessage "buildTargetPHID" to "receiverPHID" 2018-02-12 12:17:44 -08:00
HarbormasterBuildPlanQuery.php Support searching for Harbormater build plans by name substring 2016-02-29 05:22:24 -08:00
HarbormasterBuildPlanSearchEngine.php Allow Drydock blueprints to be tagged and searched, and give types some little icons 2016-03-03 15:21:58 -08:00
HarbormasterBuildPlanTransactionQuery.php Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
HarbormasterBuildQuery.php Simply how Differential drafts ignore Harbormaster autobuilds 2017-10-23 10:31:48 -07:00
HarbormasterBuildSearchEngine.php Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine 2016-08-14 08:31:02 -07:00
HarbormasterBuildStepQuery.php Add an "Abort Older Builds" build step to Harbormaster 2018-04-17 14:59:47 -07:00
HarbormasterBuildStepTransactionQuery.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
HarbormasterBuildTargetQuery.php Show external build links in applications 2015-08-15 07:29:26 -07:00
HarbormasterBuildTransactionQuery.php Remove @group annotations 2014-07-10 08:12:48 +10:00