epriestley 304467feb2 Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions ... Summary: Ref T13526. Currently, if a build plan is restricted, viewers may fatal when trying to view related builds. The old behavior allowed them to see the build even if they can not see the build plan. This is sort of incoherent, but try to stabilize things before fixing this. Test Plan: This is a muddy change. - Created a build with a build plan that Alice can't see. - As Alice, viewed the build page (restricted before, restricted after); the buildable page (fatal before, works after). - Also viewed a revision page (works before and after, but user-reported fatal). Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13526 Differential Revision: https://secure.phabricator.com/D21194		2020-04-30 07:57:23 -07:00
..
__tests__	As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers	2018-02-26 17:56:52 -08:00
application	Add a test to verify that all routing maps are plausibly valid, and remove some dead routes	2020-02-14 18:06:24 -08:00
artifact	Explicitly add rel="noreferrer" to all external links	2018-02-17 17:46:11 -08:00
autoplan	Give "Arcanist Client Results" a more clear name	2015-09-09 19:18:08 -07:00
capability	Add spelling TODOs	2017-10-09 11:56:53 -07:00
codex	Make the new Build Plan "Runnable" behavior work	2019-03-06 06:01:02 -08:00
conduit	Roughly implement "harbormaster.artifact.search"	2019-10-29 13:37:35 -07:00
constants	Add an "Restartable: If Failed" behavior to Harbormaster build plans	2019-03-07 16:47:57 -08:00
controller	Tailor "Restart All Builds" for the complex realities of modern build restart rules	2019-07-24 09:25:46 -07:00
customfield	Allow "Wait for Message" to be unset on build plans	2016-11-22 14:02:37 -08:00
editor	Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable	2019-03-06 05:40:06 -08:00
engine	Update "phabricator/" for "topological" API changes	2019-06-20 16:11:56 -07:00
engineextension	Subsume 'harbormaster.querybuilds' with a modern search API method	2016-07-31 21:44:22 +00:00
event	Reduce the severity of policy fatals when building the Harbormaster "build status" element	2018-03-16 13:27:57 -07:00
exception	Add an "Restartable: If Failed" behavior to Harbormaster build plans	2019-03-07 16:47:57 -08:00
future	Update some Phabricator behaviors for changes to Futures	2020-04-03 12:28:16 -07:00
herald	Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them	2019-09-12 14:33:28 -07:00
interface	When publishing buildables in Differential, ignore autobuilds (local lint and unit)	2018-04-03 11:02:12 -07:00
management	Move structural build publishing logic to BuildEngine, provide "bin/harbormaster publish"	2018-04-03 10:58:27 -07:00
phid	Add a very basic standalone view for build logs with a "Download Log" button	2018-02-26 17:53:10 -08:00
plan	Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans	2019-03-25 11:24:04 -07:00
query	Roughly implement "harbormaster.artifact.search"	2019-10-29 13:37:35 -07:00
remarkup	Rename PhutilRemarkupRule subclasses	2014-08-05 00:55:43 +10:00
step	When waiting for long-running Harbormaster futures to resolve, close idle database connections	2018-11-21 07:53:40 -08:00
stepgroup	Add an "Abort Older Builds" build step to Harbormaster	2018-04-17 14:59:47 -07:00
storage	Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions	2020-04-30 07:57:23 -07:00
typeahead	Search builds based on who kicked them off	2016-07-31 20:54:44 +00:00
view	In summary interfaces, don't render very large inline remarkup details for unit test messages	2020-02-05 14:26:38 -08:00
worker	Stop build target start times from being overwritten on reentry	2018-04-27 12:25:45 -07:00
xaction/plan	Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable	2019-03-06 05:40:06 -08:00