1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-20 10:48:40 +01:00
phorge-phorge/src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php
epriestley 156b156e77 Give Conduit params/return/errors protected visibility
Summary:
Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan:
  - Ran `arc unit --everything`.
  - Called `conduit.query`.
  - Browsed Conduit UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: hach-que, epriestley

Maniphest Tasks: T5873, T7803

Differential Revision: https://secure.phabricator.com/D12380
2015-04-13 11:58:35 -07:00

47 lines
1.1 KiB
PHP

<?php
final class PhrequentPopConduitAPIMethod extends PhrequentConduitAPIMethod {
public function getAPIMethodName() {
return 'phrequent.pop';
}
public function getMethodDescription() {
return pht('Stop tracking time on an object by popping it from the stack.');
}
public function getMethodStatus() {
return self::METHOD_STATUS_UNSTABLE;
}
protected function defineParamTypes() {
return array(
'objectPHID' => 'phid',
'stopTime' => 'int',
'note' => 'string',
);
}
protected function defineReturnType() {
return 'phid';
}
protected function execute(ConduitAPIRequest $request) {
$user = $request->getUser();
$object_phid = $request->getValue('objectPHID');
$timestamp = $request->getValue('stopTime');
$note = $request->getValue('note');
if ($timestamp === null) {
$timestamp = time();
}
$editor = new PhrequentTrackingEditor();
if (!$object_phid) {
return $editor->stopTrackingTop($user, $timestamp, $note);
} else {
return $editor->stopTracking($user, $object_phid, $timestamp, $note);
}
}
}