1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-29 00:40:57 +01:00
phorge-phorge/webroot/rsrc/js/application
Bob Trahan 5729bbc085 Fix transaction comment bug
Summary: form.reset() resets a form to whatever values were present when the form was loaded into the DOM. Instead, grab all the pertinent form bits and set there values to "clear". I don't think there's too much utility in putting this somewhere more general, but it could be something like DOM.clearForm(form) or something. Fixes T3629.

Test Plan:
repro'd original issue

 - open legalpad doc (or your favorite application transaction powered app)
 - type in a comment but do not submit (you are creating a draft) e.g. "foo"
 - reload page and note comment appears e.g. "foo"
 - change comment e.g. "foobar"
 - submit comment
 - BUG - after submission, the comment reverts to the comment at initial page load e.g. "foo"

then after this patch, I can't repro it anymore with these steps - the comment is correctly blank

 NOTE: this will need to be tested with more complicated forms.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T3629

Differential Revision: https://secure.phabricator.com/D8220
2014-02-13 15:10:20 -08:00
..
aphlict Make the quick create menu more or less work correctly 2014-01-28 20:19:20 -08:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
config Allow custom fields to be reordered and disabled from Config 2013-07-09 08:27:19 -07:00
conpherence Conpherence - fix some ajax bugs 2013-06-11 15:07:53 -10:00
countdown Modernize Countdown somewhat 2013-07-23 06:16:19 -07:00
differential Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00
diffusion Line highlighting for pastes 2013-08-04 12:12:37 -07:00
doorkeeper Add remarkup support for Asana URIs 2013-06-24 15:55:08 -07:00
files Add an icon+background selector for project images 2013-10-17 09:32:34 -07:00
harbormaster Implement explicit build step ordering in Harbormaster 2013-12-06 14:12:15 +11:00
herald Herald - add support for task priority 2014-02-06 11:42:31 -08:00
maniphest Burnup report showing decimals on hover 2014-01-27 13:51:19 -08:00
owners Allow excluding paths from package 2012-12-07 16:33:16 -08:00
passphrase Add "allow null" and username hinting to the Passphrase credential control 2013-11-22 14:35:35 -08:00
phame Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
pholio Pholio - back end for image re-ordering 2013-08-12 13:09:07 -07:00
phortune Allow PhortuneTestProvider to add payment methods 2013-04-25 09:50:08 -07:00
policy Allow "Custom" policies to be selected in the policy control 2013-10-14 16:59:16 -07:00
ponder Use PHUIRemarkupPreviewPanel in Ponder 2013-08-05 10:47:06 -07:00
projects Send appropriate requests to the server when dragging cards on project boards 2014-01-13 12:24:36 -08:00
releeph Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
repository Removed getElementsByClassName in repositor-crossreference.js 2013-05-12 06:54:15 -07:00
search Simplify drag-and-drop list implementations 2013-06-05 17:36:33 -07:00
slowvote Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
transactions Fix transaction comment bug 2014-02-13 15:10:20 -08:00
uiexample Fix more JavelinView example stuff 2013-07-16 13:46:49 -07:00