1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-08 13:51:02 +01:00
phorge-phorge/src/applications/owners/mail
epriestley 34db543d27 Remove all application-specific reply handler class overrides
Summary:
Ref T7199. In the vein of D12231, these options were a bad idea.

  - They once served a very narrow, Facebook-specific need (see T1992), except even Facebook only used the Differential setting AFAIK.
  - Outside of that special case, they are unused and essentially unusable (generally speaking, they do not meaningfully implement anything modular or replaceable).
  - I have no knowledge of any install ever changing these settings, and can imagine no reason why they would.

Moving forward:

  - If they really need to, they can fork locally and chagne one line.
  - I expect "!actions" to make mail at least somewhat more modular soon, anyway.
  - Any derived handlers would break after T7199 and need to be rewritten anyway, so this is just taking advantage of a BC break to do cleanup.

Test Plan:
  - Grepped for removed configuration.
  - Sent some mail from applications, verified the reply handlers set proper reply addresses.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7199

Differential Revision: https://secure.phabricator.com/D12233
2015-03-31 17:22:01 -07:00
..
OwnersPackageReplyHandler.php Remove all application-specific reply handler domains 2015-03-31 16:48:40 -07:00
PackageCreateMail.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PackageDeleteMail.php Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
PackageMail.php Remove all application-specific reply handler class overrides 2015-03-31 17:22:01 -07:00
PackageModifyMail.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00