1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/legalpad
Bob Trahan 9838251515 Make PhabricatorActionListView logged-out user savvy
Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416
2013-07-12 11:39:47 -07:00
..
application Legalpad - add signature page 2013-07-10 11:46:39 -07:00
config Legalpad V0.2 - add mail integration 2013-07-03 16:37:05 -07:00
constants Legalpad V0.1 2013-07-03 11:15:45 -07:00
controller Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
editor Legalpad - add signature page 2013-07-10 11:46:39 -07:00
mail Legalpad V0.2 - add mail integration 2013-07-03 16:37:05 -07:00
query Legalpad - denormalize a field or two from DocumentBody to Document 2013-07-08 17:06:49 -07:00
storage Legalpad - add signature page 2013-07-10 11:46:39 -07:00
view Legalpad V0.1 2013-07-03 11:15:45 -07:00