mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 01:02:42 +01:00
1830868007
Summary: ...by the surprising step of changing how this data is stored from id to phid. Also a small fix to not allow "disabled" rules to be used as herald rule conditions, i.e. can't make a rule that depends on a disabled rule. Test Plan: viewed existing herald rule that had a rule condition and noted nice new display using handle. made a new rule that had a rule condition and verified it worked correctly. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8186
31 lines
760 B
PHP
31 lines
760 B
PHP
<?php
|
|
|
|
$table = new HeraldCondition();
|
|
$conn_w = $table->establishConnection('w');
|
|
|
|
echo "Migrating Herald conditions of type Herald rule from IDs to PHIDs...\n";
|
|
foreach (new LiskMigrationIterator($table) as $condition) {
|
|
if ($condition->getFieldName() != HeraldAdapter::FIELD_RULE) {
|
|
continue;
|
|
}
|
|
|
|
$value = $condition->getValue();
|
|
if (!is_numeric($value)) {
|
|
continue;
|
|
}
|
|
$id = $condition->getID();
|
|
echo "Updating condition {$id}...\n";
|
|
|
|
$rule = id(new HeraldRuleQuery())
|
|
->setViewer(PhabricatorUser::getOmnipotentUser())
|
|
->withIDs(array($value))
|
|
->executeOne();
|
|
|
|
queryfx(
|
|
$conn_w,
|
|
'UPDATE %T SET value = %s WHERE id = %d',
|
|
$table->getTableName(),
|
|
json_encode($rule->getPHID()),
|
|
$id);
|
|
}
|
|
echo "Done.\n";
|