revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 31e623afcc Use the same transaction group ID for transactions applied indirectly by a sub-editor 
Summary:
Ref T13283. Currently, each Editor sets its own group ID, so if you create a revision and then Herald does some stuff, the two groups of transactions get different group IDs.

This means the test console is slightly misleading (it will only pick up the Herald transactions). It's going to be misleading anyway (Herald obviously can't evaluate Herald transactions) but this is at least a little closer to reality and stops Herald actions from masking non-Herald actions.

Test Plan:
  - Created a revision. Herald applied one transaction.
  - Used the test console.
  - Before: The test console only picked up the single most recent Herald transaction.
  - After: The test console picked up the whole transaction group.

{F6464059}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13283

Differential Revision: https://secure.phabricator.com/D20546
2019-05-22 16:33:03 -07:00
..
almanac Convert complex query subclasses to use internal cursors 2019-03-19 13:02:16 -07:00
aphlict Add a CLI workflow for testing that notifications are being delivered 2018-12-10 16:05:53 -08:00
arcanist/conduit
audit Prevent "Differential Revision: ..." from counting as a mention in commit messages 2019-05-22 16:22:01 -07:00
auth Implement Asana and JIRA external links via HyperlinkEngineExtension, not separate Remarkup rules 2019-05-21 12:15:39 -07:00
badges Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
base Don't show a "Manage" button in Legalpad if the user is signing a TOS document 2019-03-25 11:30:46 -07:00
cache Remove an old digest in Celerity code and some obsolete configuration options 2019-01-04 13:43:38 -08:00
calendar Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
celerity Fix "Actions" button on Phame standalone/live pages (bonus: JX.sprintf()) 2019-04-04 06:10:14 -07:00
chatlog Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
conduit Fix an exception with user cache generation in "bin/conduit call --as <user>" 2019-03-07 11:48:24 -08:00
config Don't warn about a locked database value after users run "bin/auth lock" 2019-04-17 19:54:11 -07:00
conpherence Improve Conpherence behavior for logged out users. 2019-04-02 14:03:08 -07:00
console Fix some minor errors (DarkConsole warning, unstable Ferret sort) 2018-03-18 15:12:25 -07:00
countdown Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
daemon Start the fact daemon in "bin/phd start" 2019-05-22 04:57:55 -07:00
dashboard Consolidate burndown logic into a "BurndownChartEngine" 2019-05-22 05:10:42 -07:00
differential Drop the "update revision with commit diff" transaction if the revision is already closed 2019-05-22 16:26:45 -07:00
diffusion Prevent "Differential Revision: ..." from counting as a mention in commit messages 2019-05-22 16:22:01 -07:00
diviner Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
doorkeeper Recognize self-URI links to Diffusion files and give them special rendering behavior 2019-05-21 13:07:37 -07:00
draft/storage When purging drafts after a transaction edit, purge all drafts 2018-02-11 06:01:09 -08:00
drydock Fix a typo in Drydock "Land" operations 2019-03-15 14:53:05 -07:00
fact Stack chart functions in a more physical way 2019-05-22 05:40:39 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Support export of feed transactions to CSV/Excel/etc 2019-05-21 12:47:46 -07:00
files Replace all "setQueryParam()" calls with "remove/replaceQueryParam()" 2019-02-14 11:56:39 -08:00
flag Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
fund Improve UI/UX when users try to add an invalid card with Stripe 2019-02-09 05:54:42 -08:00
guides Remove legacy "DashboardInstall" table 2019-04-14 10:27:52 -07:00
harbormaster Provide a clearer UI for "view all results" in partial result panels 2019-03-25 14:35:08 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Label transaction groups with a "group ID" so Herald can reconstruct them faithfully 2019-05-17 12:07:37 -07:00
home Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
legalpad Don't show a "Manage" button in Legalpad if the user is signing a TOS document 2019-03-25 11:30:46 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Improve timeline rendering for old macros 2019-04-18 18:25:17 -07:00
maniphest Stabilize sorting of feed stories with similar strength 2019-05-22 15:50:59 -07:00
meta Recognize self-URI links to Diffusion files and give them special rendering behavior 2019-05-21 13:07:37 -07:00
metamta Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers" 2019-03-16 12:35:55 -07:00
multimeter Fix a PhutilURI issue in Multimeter 2019-02-17 17:39:34 -08:00
notification Add "Move Left" and "Move Right" to dashboard tab panels 2019-05-01 15:35:53 -07:00
nuance Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
oauthserver Replace all "setQueryParam()" calls with "remove/replaceQueryParam()" 2019-02-14 11:56:39 -08:00
owners Index and show Owners packages affected by Herald rules 2019-04-17 12:17:30 -07:00
packages Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
passphrase Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
paste Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
people Fix some overlooked profile menu construction callsites 2019-04-09 14:47:44 -07:00
phame Fix "Actions" button on Phame standalone/live pages (bonus: JX.sprintf()) 2019-04-04 06:10:14 -07:00
phid Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes 2019-04-14 10:28:19 -07:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Stabilize sorting of feed stories with similar strength 2019-05-22 15:50:59 -07:00
phortune Remove WePay support from Phortune, and Restful/Httpful dependencies 2019-05-14 09:14:53 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email 2019-05-22 16:28:25 -07:00
phurl Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
policy Update "bin/policy unlock" to be more surgical, flexible, modular, and modern 2019-03-07 12:24:25 -08:00
ponder Fix a missing pht() in Ponder 2019-04-12 12:18:56 -07:00
project Stack chart functions in a more physical way 2019-05-22 05:40:39 -07:00
releeph Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
remarkup Recognize self-URI links to Diffusion files and give them special rendering behavior 2019-05-21 13:07:37 -07:00
repository Prevent "Differential Revision: ..." from counting as a mention in commit messages 2019-05-22 16:22:01 -07:00
search Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class 2019-05-16 11:14:49 -07:00
settings Fix two minor timezone display issues 2019-03-25 10:53:36 -07:00
slowvote Fix two very, very minor correctness issues in Slowvote 2019-02-07 12:45:11 -08:00
spaces Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" 2019-02-07 14:56:38 -08:00
subscriptions Index and show Owners packages affected by Herald rules 2019-04-17 12:17:30 -07:00
support/application
system Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked 2019-03-07 12:27:11 -08:00
tokens Allow tokens to be awarded to MFA-required objects 2018-12-28 00:14:48 -08:00
transactions Use the same transaction group ID for transactions applied indirectly by a sub-editor 2019-05-22 16:33:03 -07:00
typeahead Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00