1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential/constants
Andrew Gallagher 3223defe96 Add support for postponed linters
Summary:
This adds:
1) A new "arc:lint-postponed" diff property which stores a list of
lint names that are postponed and a finishpostponedlinters conduit
method which removes linters from this list.  Postponed linters are
shown in the lint details.
2) A updatelintmessages conduit message, which adds additional lint
messages to the "arc:lint" diff property.

In combination, this provides very basic support for running
asynchronous static analysis tools.  When the diff is being created,
a list of asynchronous static analysis runs can be added to the
diff's postponed linters list.  As these postponed linters finish
up, then can report new lint messages back to the diff then mark
themselves as complete.

The client is currently responsible for filtering the lint messages
by things like affected lines and files.

Test Plan:
Used conduit call API to add lint messages and remove postponed
linters from a test diff.

Reviewers: epriestley, vrana, nh, jungejason

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1332

Differential Revision: https://secure.phabricator.com/D2792
2012-06-28 18:09:38 -07:00
..
DifferentialAction.php Mark 'closed' as translatable 2012-06-15 11:52:03 -07:00
DifferentialChangeType.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
DifferentialLintStatus.php Add support for postponed linters 2012-06-28 18:09:38 -07:00
DifferentialMailPhase.php Drive Differential review request e-mail message by field specification 2012-06-06 18:07:47 -07:00
DifferentialRevisionControlSystem.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
DifferentialUnitStatus.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
DifferentialUnitTestResult.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00