1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 16:00:59 +01:00
phorge-phorge/externals
Valerio Bozzolan 71e4eee275 Update Figlet implementation to be PHP8 compatible
Summary:
As of PHP ~v8 the zip_open and associated functions have been deprecated and
removed. The replacement is the ZipArchive API. This updates the figlet
implementation to use this API which has been present in PHP since 5.2.

Additionally in PHP 8 the use of squiggly brackets for indexing into arrays
is also deprecated. This updates to remove two uses of squiggly brackets and
replace with square brackets.

These two deprecations would result in being unable to load differential
revisions in which someone had commented using figlet remarkup.

Imported from:

https://secure.phabricator.com/rPd5c63c86e7e4e87d5f72b35b1bdb1e888aea49bc

https://secure.phabricator.com/rPbc6f4786a2e36441d17b765fde8e8e047840bc58

Closes T15289

Test Plan:
Applied these changes to an install and loaded a revision that had comments
where someone utilized figlet remarkup. The revision loaded properly and the
figlet comment rendered properly.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15064, T15289

Differential Revision: https://we.phorge.it/D25142
2023-06-05 09:16:57 -04:00
..
cldr Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency 2020-02-12 15:17:36 -08:00
cowsay Cleanup unused cowsay files (related to legacy Perl binary version) 2023-05-29 09:13:44 +02:00
figlet Include "Figlet" and PEAR "Text_Figlet" in externals 2015-09-13 12:30:48 -07:00
JsShrink Update JsShrink external library. 2014-06-07 11:26:20 -07:00
mimemailparser Backport fix from php-mime-mail-parser to fix attachment parsing 2016-09-21 15:04:20 -07:00
octicons Add profile images to Repositories 2017-06-12 07:51:39 -07:00
pear-figlet Update Figlet implementation to be PHP8 compatible 2023-06-05 09:16:57 -04:00
phpmailer replace usage of each() with foreach() for smtp 2023-03-03 19:27:57 +01:00
phpqrcode Quickly fix phpqrcode syntax 2015-08-31 14:05:51 -07:00
porter-stemmer Update deprecated array access syntax in Porter stemmer 2020-01-14 12:11:39 -08:00
stripe-php Update Stripe PHP API 2014-07-13 09:19:07 -07:00
wordlist Add a common password blacklist 2014-01-23 14:01:18 -08:00
xhprof Fix some issues caught by HipHop, and work around some issues 2011-02-26 21:01:42 -08:00