mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 23:02:42 +01:00
da40f80741
Summary: Ref T13217. This method is slightly tricky: - We can't safely return a string: return an array instead. - It no longer makes sense to accept glue. All callers use `', '` as glue anyway, so hard-code that. Then convert all callsites. Test Plan: Browsed around, saw fewer "unsafe" errors in error log. Reviewers: amckinley Reviewed By: amckinley Subscribers: yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13217 Differential Revision: https://secure.phabricator.com/D19784
53 lines
1.2 KiB
PHP
53 lines
1.2 KiB
PHP
<?php
|
|
|
|
// Was PhabricatorEdgeConfig::TYPE_COLUMN_HAS_OBJECT
|
|
$type_has_object = 44;
|
|
|
|
$column = new PhabricatorProjectColumn();
|
|
$conn_w = $column->establishConnection('w');
|
|
|
|
$rows = queryfx_all(
|
|
$conn_w,
|
|
'SELECT src, dst FROM %T WHERE type = %d',
|
|
PhabricatorEdgeConfig::TABLE_NAME_EDGE,
|
|
$type_has_object);
|
|
|
|
$cols = array();
|
|
foreach ($rows as $row) {
|
|
$cols[$row['src']][] = $row['dst'];
|
|
}
|
|
|
|
$sql = array();
|
|
foreach ($cols as $col_phid => $obj_phids) {
|
|
echo pht("Migrating column '%s'...", $col_phid)."\n";
|
|
$column = id(new PhabricatorProjectColumn())->loadOneWhere(
|
|
'phid = %s',
|
|
$col_phid);
|
|
if (!$column) {
|
|
echo pht("Column '%s' does not exist.", $col_phid)."\n";
|
|
continue;
|
|
}
|
|
|
|
$sequence = 0;
|
|
foreach ($obj_phids as $obj_phid) {
|
|
$sql[] = qsprintf(
|
|
$conn_w,
|
|
'(%s, %s, %s, %d)',
|
|
$column->getProjectPHID(),
|
|
$column->getPHID(),
|
|
$obj_phid,
|
|
$sequence++);
|
|
}
|
|
}
|
|
|
|
echo pht('Inserting rows...')."\n";
|
|
foreach (PhabricatorLiskDAO::chunkSQL($sql) as $chunk) {
|
|
queryfx(
|
|
$conn_w,
|
|
'INSERT INTO %T (boardPHID, columnPHID, objectPHID, sequence)
|
|
VALUES %LQ',
|
|
id(new PhabricatorProjectColumnPosition())->getTableName(),
|
|
$chunk);
|
|
}
|
|
|
|
echo pht('Done.')."\n";
|