1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/infrastructure
epriestley 32d23254c9 Use --user and --password from bin/storage in PHP migrations
Summary:
Fixes T2059. Ref T2517.

Currently, you can run `bin/storage upgrade` with `--user` and `--password` arguments. However, these clownishly apply only to `.sql` patches -- the `.php` migrations still use the default user and password.

This is dumb. Stop doing it. Respect `--user` and `--password` for PHP patches.

(I implemented "override", which is very similar to "repair", but kept them separate since I think they're semantically distinct enough to differentiate.)

Test Plan: Ran `./bin/storage upgrade --user x --pass y --apply phabricator:20130219.commitsummarymig.php`. Verified the correct user and password were used both for the initial connect and patch application.

Reviewers: chad, vrana

Reviewed By: chad

CC: aran

Maniphest Tasks: T2059, T2517

Differential Revision: https://secure.phabricator.com/D5115
2013-02-25 22:20:23 -08:00
..
__tests__ Formalize configuration sources and source stacks 2012-12-25 06:44:29 -08:00
celerity Tokens v1 2013-02-15 07:47:14 -08:00
daemon Allow files to TTL and and be garbage collected 2013-02-20 13:38:36 -08:00
diff Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
edges Conpherence V1 2013-01-24 17:23:05 -08:00
env Use --user and --password from bin/storage in PHP migrations 2013-02-25 22:20:23 -08:00
events Tokens v1 2013-02-15 07:47:14 -08:00
internationalization Display application status in tip for needs attention number 2013-02-21 14:57:24 -08:00
javelin Merge branch 'master' into phutil_tag 2013-02-04 06:19:52 -08:00
lint Make PhabricatorLintEngine extensible 2013-02-19 11:37:25 -08:00
markup Unparse/escape macros with commas, etc., correctly 2013-02-21 16:36:54 -08:00
query Delete license headers from files 2012-11-05 11:16:51 -08:00
ssh Implement SSHD glue and Conduit SSH endpoint 2012-12-19 11:08:07 -08:00
storage SQL patch to drop channel field. 2013-02-22 07:29:40 -08:00
testing Don't pop invalid test environment 2013-01-17 12:01:46 -08:00
util Add PhabricatorHash::digestForIndex() 2012-12-21 05:43:33 -08:00
PhabricatorAccessLog.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorEditor.php Delete license headers from files 2012-11-05 11:16:51 -08:00