mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 16:22:43 +01:00
e0f99484ac
Summary: Ref T603. Make Differential behaviors for logged-out and underprivleged users more similar to other apps. I'm going to drop this "anonymous access" thing at some point, but `reviews.fb.net` actually looks like it's running semi-modern code, so leave it alive until we have a more compelling replacement in the upstream. Test Plan: As a logged out user, browsed Differential and clicked things and such. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7148
140 lines
3.3 KiB
PHP
140 lines
3.3 KiB
PHP
<?php
|
|
|
|
final class DifferentialDiffQuery
|
|
extends PhabricatorCursorPagedPolicyAwareQuery {
|
|
|
|
private $ids;
|
|
private $revisionIDs;
|
|
private $needChangesets = false;
|
|
private $needArcanistProjects = false;
|
|
|
|
public function withIDs(array $ids) {
|
|
$this->ids = $ids;
|
|
return $this;
|
|
}
|
|
|
|
public function withRevisionIDs(array $revision_ids) {
|
|
$this->revisionIDs = $revision_ids;
|
|
return $this;
|
|
}
|
|
|
|
public function needChangesets($bool) {
|
|
$this->needChangesets = $bool;
|
|
return $this;
|
|
}
|
|
|
|
public function needArcanistProjects($bool) {
|
|
$this->needArcanistProjects = $bool;
|
|
return $this;
|
|
}
|
|
|
|
public function loadPage() {
|
|
$table = new DifferentialDiff();
|
|
$conn_r = $table->establishConnection('r');
|
|
|
|
$data = queryfx_all(
|
|
$conn_r,
|
|
'SELECT * FROM %T %Q %Q %Q',
|
|
$table->getTableName(),
|
|
$this->buildWhereClause($conn_r),
|
|
$this->buildOrderClause($conn_r),
|
|
$this->buildLimitClause($conn_r));
|
|
|
|
return $table->loadAllFromArray($data);
|
|
}
|
|
|
|
public function willFilterPage(array $diffs) {
|
|
$revision_ids = array_filter(mpull($diffs, 'getRevisionID'));
|
|
|
|
$revisions = array();
|
|
if ($revision_ids) {
|
|
$revisions = id(new DifferentialRevisionQuery())
|
|
->setViewer($this->getViewer())
|
|
->withIDs($revision_ids)
|
|
->execute();
|
|
}
|
|
|
|
foreach ($diffs as $key => $diff) {
|
|
if (!$diff->getRevisionID()) {
|
|
$diff->attachRevision(null);
|
|
continue;
|
|
}
|
|
|
|
$revision = idx($revisions, $diff->getRevisionID());
|
|
if ($revision) {
|
|
$diff->attachRevision($revision);
|
|
continue;
|
|
}
|
|
|
|
unset($diffs[$key]);
|
|
}
|
|
|
|
|
|
if ($this->needChangesets) {
|
|
$this->loadChangesets($diffs);
|
|
}
|
|
|
|
if ($this->needArcanistProjects) {
|
|
$this->loadArcanistProjects($diffs);
|
|
}
|
|
|
|
return $diffs;
|
|
}
|
|
|
|
private function loadChangesets(array $diffs) {
|
|
foreach ($diffs as $diff) {
|
|
$diff->attachChangesets(
|
|
$diff->loadRelatives(new DifferentialChangeset(), 'diffID'));
|
|
foreach ($diff->getChangesets() as $changeset) {
|
|
$changeset->attachHunks(
|
|
$changeset->loadRelatives(new DifferentialHunk(), 'changesetID'));
|
|
}
|
|
}
|
|
return $diffs;
|
|
}
|
|
|
|
private function loadArcanistProjects(array $diffs) {
|
|
$phids = array_filter(mpull($diffs, 'getArcanistProjectPHID'));
|
|
$projects = array();
|
|
$project_map = array();
|
|
if ($phids) {
|
|
$projects = id(new PhabricatorRepositoryArcanistProject())
|
|
->loadAllWhere(
|
|
'phid IN (%Ls)',
|
|
$phids);
|
|
$project_map = mpull($projects, null, 'getPHID');
|
|
}
|
|
|
|
foreach ($diffs as $diff) {
|
|
$project = null;
|
|
if ($diff->getArcanistProjectPHID()) {
|
|
$project = idx($project_map, $diff->getArcanistProjectPHID());
|
|
}
|
|
$diff->attachArcanistProject($project);
|
|
}
|
|
|
|
return $diffs;
|
|
}
|
|
|
|
private function buildWhereClause(AphrontDatabaseConnection $conn_r) {
|
|
$where = array();
|
|
|
|
if ($this->ids) {
|
|
$where[] = qsprintf(
|
|
$conn_r,
|
|
'id IN (%Ld)',
|
|
$this->ids);
|
|
}
|
|
|
|
if ($this->revisionIDs) {
|
|
$where[] = qsprintf(
|
|
$conn_r,
|
|
'revisionID IN (%Ld)',
|
|
$this->revisionIDs);
|
|
}
|
|
|
|
$where[] = $this->buildPagingClause($conn_r);
|
|
return $this->formatWhereClause($where);
|
|
}
|
|
|
|
}
|