mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 00:02:41 +01:00
575c01373e
Summary: Ref T4292. Ref T10366. Depends on D15751. Today, generating repository commands is purely a function of the repository, so they use protocols and credentials based on the repository configuration. For example, a repository with an SSH "remote URI" always generate SSH "remote commands". This needs to change in the future: - After T10366, repositories won't necessarily just have one type of remote URI. They can only have one at a time still, but the repository itself won't change based on which one is currently active. - For T4292, I need to generate intracluster commands, regardless of repository configuration. These will have different protocols and credentials. Prepare for these cases by separating out command construction, so they'll be able to generate commands in a more flexible way. Test Plan: - Added unit tests. - Browsed diffusion. - Ran `bin/phd debug pull` to pull a bunch of repos. - Ran daemons. Reviewers: chad Reviewed By: chad Maniphest Tasks: T4292, T10366 Differential Revision: https://secure.phabricator.com/D15752
54 lines
1.2 KiB
PHP
54 lines
1.2 KiB
PHP
<?php
|
|
|
|
final class DiffusionSubversionCommandEngine
|
|
extends DiffusionCommandEngine {
|
|
|
|
protected function canBuildForRepository(
|
|
PhabricatorRepository $repository) {
|
|
return $repository->isSVN();
|
|
}
|
|
|
|
protected function newFormattedCommand($pattern, array $argv) {
|
|
$flags = array();
|
|
$args = array();
|
|
|
|
$flags[] = '--non-interactive';
|
|
|
|
if ($this->isAnyHTTPProtocol() || $this->isSVNProtocol()) {
|
|
$flags[] = '--no-auth-cache';
|
|
|
|
if ($this->isAnyHTTPProtocol()) {
|
|
$flags[] = '--trust-server-cert';
|
|
}
|
|
|
|
$credential_phid = $this->getCredentialPHID();
|
|
if ($credential_phid) {
|
|
$key = PassphrasePasswordKey::loadFromPHID(
|
|
$credential_phid,
|
|
PhabricatorUser::getOmnipotentUser());
|
|
|
|
$flags[] = '--username %P';
|
|
$args[] = $key->getUsernameEnvelope();
|
|
|
|
$flags[] = '--password %P';
|
|
$args[] = $key->getPasswordEnvelope();
|
|
}
|
|
}
|
|
|
|
$flags = implode(' ', $flags);
|
|
$pattern = "svn {$flags} {$pattern}";
|
|
|
|
return array($pattern, array_merge($args, $argv));
|
|
}
|
|
|
|
protected function newCustomEnvironment() {
|
|
$env = array();
|
|
|
|
if ($this->isAnySSHProtocol()) {
|
|
$env['SVN_SSH'] = $this->getSSHWrapper();
|
|
}
|
|
|
|
return $env;
|
|
}
|
|
|
|
}
|