1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-03 02:18:24 +01:00
phorge-phorge/src
epriestley 33bce22ef2 Never return external connections to the GlobalLock connection pool
Summary:
Ref T13627. If a lock fails, the connection may be returned to the pool, even if the connection is an external connection. Under old versions of MySQL, connection reuse can release other locks on the same connection.

Don't return external connections to the pool.

This issue was introduced in D21369.

Test Plan: Added a failing test and made it pass.

Maniphest Tasks: T13627

Differential Revision: https://secure.phabricator.com/D21585
2021-03-02 13:44:17 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Restructure Hovercards to support more context information 2021-02-13 13:37:36 -08:00
applications Prevent external connections from being mutated on held locks 2021-03-02 13:44:16 -08:00
docs Update install and upgrade documentation for libphutil 2021-02-08 10:20:00 -08:00
extensions
infrastructure Never return external connections to the GlobalLock connection pool 2021-03-02 13:44:17 -08:00
view When a reviewer can't see a revision, show it clearly in the reviewer list 2021-02-13 13:37:37 -08:00
__phutil_library_init__.php
__phutil_library_map__.php When a GlobalLock with an external connection is released, don't return it to the pool 2021-03-02 13:44:16 -08:00