1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 15:00:58 +01:00
phorge-phorge/src/applications/audit
epriestley 341079c3cf Move some received mail responsibility to applications
Summary:
Ref T1205. Continuation of D5915.

Currently, `PhabricatorMetaMTAReceivedMail` has //all// the logic for routing mail. In particular:

  - New mail receivers in applications must edit it.
  - Mail receivers don't drop out when applications are uninstalled.

Applications have some logic in subclasses of `PhabricatorMailReplyHandler`, but this class is a bit of a mess. It is also heavily based on the assumption that mail receivers are objects (like revisions), but this is not true in at least two cases today (creating new tasks with `bugs@`, creating a new Conpherence thread) and likely other cases in the future (e.g., revision-by-mail).

Move this logic into a new `PhabricatorMailReceiver` classtree. This is similar to `PhabricatorMailReplyHandler` but a bit cleaner and more general. I plan to heavily reduce the responsibilities of `PhabricatorMailReplyHandler` or possibly eliminate it entirely.

For now, the new classtree doesn't do much of interest. The only behavioral change this diff causes is that Phabricator will now reject mail to an application when that application is uninstalled.

I also moved all the `ReplyHandler` classes into `mail/` directories in their respective applications.

Test Plan: Unit tests, used receive test to route mail to various objects.

Reviewers: btrahan

Reviewed By: btrahan

CC: Afaque_Hussain, edward, aran

Maniphest Tasks: T1205

Differential Revision: https://secure.phabricator.com/D5922
2013-05-14 10:57:41 -07:00
..
application Fix audit counts in some queries 2013-02-28 15:01:32 -08:00
conduit Uninstall Conduit calls when uninstalling applications 2013-03-13 07:09:05 -07:00
constants enabled Audit to filter Concern vs. No-Concern status 2013-02-28 07:57:02 -08:00
controller Fix audit counts in some queries 2013-02-28 15:01:32 -08:00
editor Require a viewer to load handles 2013-02-28 17:15:09 -08:00
events Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
mail Move some received mail responsibility to applications 2013-05-14 10:57:41 -07:00
query Revert audit queries back to original behavior 2013-03-04 14:03:14 -08:00
storage Delete license headers from files 2012-11-05 11:16:51 -08:00
view Remove logic which hides commit names in commit table when they're the same as previous commit names 2013-04-07 15:50:21 -07:00