mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-21 11:09:02 +01:00
341079c3cf
Summary: Ref T1205. Continuation of D5915. Currently, `PhabricatorMetaMTAReceivedMail` has //all// the logic for routing mail. In particular: - New mail receivers in applications must edit it. - Mail receivers don't drop out when applications are uninstalled. Applications have some logic in subclasses of `PhabricatorMailReplyHandler`, but this class is a bit of a mess. It is also heavily based on the assumption that mail receivers are objects (like revisions), but this is not true in at least two cases today (creating new tasks with `bugs@`, creating a new Conpherence thread) and likely other cases in the future (e.g., revision-by-mail). Move this logic into a new `PhabricatorMailReceiver` classtree. This is similar to `PhabricatorMailReplyHandler` but a bit cleaner and more general. I plan to heavily reduce the responsibilities of `PhabricatorMailReplyHandler` or possibly eliminate it entirely. For now, the new classtree doesn't do much of interest. The only behavioral change this diff causes is that Phabricator will now reject mail to an application when that application is uninstalled. I also moved all the `ReplyHandler` classes into `mail/` directories in their respective applications. Test Plan: Unit tests, used receive test to route mail to various objects. Reviewers: btrahan Reviewed By: btrahan CC: Afaque_Hussain, edward, aran Maniphest Tasks: T1205 Differential Revision: https://secure.phabricator.com/D5922
72 lines
2.1 KiB
PHP
72 lines
2.1 KiB
PHP
<?php
|
|
|
|
abstract class PhabricatorMailReceiver {
|
|
|
|
|
|
abstract public function isEnabled();
|
|
abstract public function canAcceptMail(PhabricatorMetaMTAReceivedMail $mail);
|
|
|
|
/**
|
|
* Determine if two inbound email addresses are effectively identical. This
|
|
* method strips and normalizes addresses so that equivalent variations are
|
|
* correctly detected as identical. For example, these addresses are all
|
|
* considered to match one another:
|
|
*
|
|
* "Abraham Lincoln" <alincoln@example.com>
|
|
* alincoln@example.com
|
|
* <ALincoln@example.com>
|
|
* "Abraham" <phabricator+ALINCOLN@EXAMPLE.COM> # With configured prefix.
|
|
*
|
|
* @param string Email address.
|
|
* @param string Another email address.
|
|
* @return bool True if addresses match.
|
|
*/
|
|
public static function matchAddresses($u, $v) {
|
|
$u = id(new PhutilEmailAddress($u))->getAddress();
|
|
$v = id(new PhutilEmailAddress($v))->getAddress();
|
|
|
|
$u = self::stripMailboxPrefix($u);
|
|
$v = self::stripMailboxPrefix($v);
|
|
|
|
$u = trim(phutil_utf8_strtolower($u));
|
|
$v = trim(phutil_utf8_strtolower($v));
|
|
|
|
return ($u === $v);
|
|
}
|
|
|
|
|
|
/**
|
|
* Strip a global mailbox prefix from an address if it is present. Phabricator
|
|
* can be configured to prepend a prefix to all reply addresses, which can
|
|
* make forwarding rules easier to write. A prefix looks like:
|
|
*
|
|
* example@phabricator.example.com # No Prefix
|
|
* phabricator+example@phabricator.example.com # Prefix "phabricator"
|
|
*
|
|
* @param string Email address, possibly with a mailbox prefix.
|
|
* @return string Email address with any prefix stripped.
|
|
*/
|
|
public static function stripMailboxPrefix($address) {
|
|
$address = id(new PhutilEmailAddress($address))->getAddress();
|
|
|
|
$prefix_key = 'metamta.single-reply-handler-prefix';
|
|
$prefix = PhabricatorEnv::getEnvConfig($prefix_key);
|
|
|
|
$len = strlen($prefix);
|
|
|
|
if ($len) {
|
|
$prefix = $prefix.'+';
|
|
$len = $len + 1;
|
|
}
|
|
|
|
if ($len) {
|
|
if (!strncasecmp($address, $prefix, $len)) {
|
|
$address = substr($address, strlen($prefix));
|
|
}
|
|
}
|
|
|
|
return $address;
|
|
}
|
|
|
|
|
|
}
|