mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 10:12:41 +01:00
341079c3cf
Summary: Ref T1205. Continuation of D5915. Currently, `PhabricatorMetaMTAReceivedMail` has //all// the logic for routing mail. In particular: - New mail receivers in applications must edit it. - Mail receivers don't drop out when applications are uninstalled. Applications have some logic in subclasses of `PhabricatorMailReplyHandler`, but this class is a bit of a mess. It is also heavily based on the assumption that mail receivers are objects (like revisions), but this is not true in at least two cases today (creating new tasks with `bugs@`, creating a new Conpherence thread) and likely other cases in the future (e.g., revision-by-mail). Move this logic into a new `PhabricatorMailReceiver` classtree. This is similar to `PhabricatorMailReplyHandler` but a bit cleaner and more general. I plan to heavily reduce the responsibilities of `PhabricatorMailReplyHandler` or possibly eliminate it entirely. For now, the new classtree doesn't do much of interest. The only behavioral change this diff causes is that Phabricator will now reject mail to an application when that application is uninstalled. I also moved all the `ReplyHandler` classes into `mail/` directories in their respective applications. Test Plan: Unit tests, used receive test to route mail to various objects. Reviewers: btrahan Reviewed By: btrahan CC: Afaque_Hussain, edward, aran Maniphest Tasks: T1205 Differential Revision: https://secure.phabricator.com/D5922
554 lines
17 KiB
PHP
554 lines
17 KiB
PHP
<?php
|
|
|
|
final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {
|
|
|
|
protected $headers = array();
|
|
protected $bodies = array();
|
|
protected $attachments = array();
|
|
protected $status = '';
|
|
|
|
protected $relatedPHID;
|
|
protected $authorPHID;
|
|
protected $message;
|
|
protected $messageIDHash = '';
|
|
|
|
public function getConfiguration() {
|
|
return array(
|
|
self::CONFIG_SERIALIZATION => array(
|
|
'headers' => self::SERIALIZATION_JSON,
|
|
'bodies' => self::SERIALIZATION_JSON,
|
|
'attachments' => self::SERIALIZATION_JSON,
|
|
),
|
|
) + parent::getConfiguration();
|
|
}
|
|
|
|
public function setHeaders(array $headers) {
|
|
// Normalize headers to lowercase.
|
|
$normalized = array();
|
|
foreach ($headers as $name => $value) {
|
|
$name = $this->normalizeMailHeaderName($name);
|
|
if ($name == 'message-id') {
|
|
$this->setMessageIDHash(PhabricatorHash::digestForIndex($value));
|
|
}
|
|
$normalized[$name] = $value;
|
|
}
|
|
$this->headers = $normalized;
|
|
return $this;
|
|
}
|
|
|
|
public function getHeader($key, $default = null) {
|
|
$key = $this->normalizeMailHeaderName($key);
|
|
return idx($this->headers, $key, $default);
|
|
}
|
|
|
|
private function normalizeMailHeaderName($name) {
|
|
return strtolower($name);
|
|
}
|
|
|
|
public function getMessageID() {
|
|
return $this->getHeader('Message-ID');
|
|
}
|
|
|
|
public function getSubject() {
|
|
return $this->getHeader('Subject');
|
|
}
|
|
|
|
public function getCCAddresses() {
|
|
return $this->getRawEmailAddresses(idx($this->headers, 'cc'));
|
|
}
|
|
|
|
public function getToAddresses() {
|
|
return $this->getRawEmailAddresses(idx($this->headers, 'to'));
|
|
}
|
|
|
|
private function loadExcludeMailRecipientPHIDs() {
|
|
$addresses = array_merge(
|
|
$this->getToAddresses(),
|
|
$this->getCCAddresses());
|
|
|
|
return $this->loadPHIDsFromAddresses($addresses);
|
|
}
|
|
|
|
final public function loadCCPHIDs() {
|
|
return $this->loadPHIDsFromAddresses($this->getCCAddresses());
|
|
}
|
|
|
|
private function loadPHIDsFromAddresses(array $addresses) {
|
|
if (empty($addresses)) {
|
|
return array();
|
|
}
|
|
$users = id(new PhabricatorUserEmail())
|
|
->loadAllWhere('address IN (%Ls)', $addresses);
|
|
$user_phids = mpull($users, 'getUserPHID');
|
|
|
|
$mailing_lists = id(new PhabricatorMetaMTAMailingList())
|
|
->loadAllWhere('email in (%Ls)', $addresses);
|
|
$mailing_list_phids = mpull($mailing_lists, 'getPHID');
|
|
|
|
return array_merge($user_phids, $mailing_list_phids);
|
|
}
|
|
|
|
/**
|
|
* Parses "to" addresses, looking for a public create email address
|
|
* first and if not found parsing the "to" address for reply handler
|
|
* information: receiver name, user id, and hash. If nothing can be
|
|
* found, it then loads user phids for as many to: email addresses as
|
|
* it can, theoretically falling back to create a conpherence amongst
|
|
* those users.
|
|
*/
|
|
private function getPhabricatorToInformation() {
|
|
// Only one "public" create address so far
|
|
$create_task = PhabricatorEnv::getEnvConfig(
|
|
'metamta.maniphest.public-create-email');
|
|
|
|
// For replies, look for an object address with a format like:
|
|
// D291+291+b0a41ca848d66dcc@example.com
|
|
$single_handle_prefix = PhabricatorEnv::getEnvConfig(
|
|
'metamta.single-reply-handler-prefix');
|
|
|
|
$prefixPattern = ($single_handle_prefix)
|
|
? preg_quote($single_handle_prefix, '/') . '\+'
|
|
: '';
|
|
$pattern = "/^{$prefixPattern}((?:D|T|C|E)\d+)\+([\w]+)\+([a-f0-9]{16})@/U";
|
|
|
|
$phabricator_address = null;
|
|
$receiver_name = null;
|
|
$user_id = null;
|
|
$hash = null;
|
|
$user_phids = array();
|
|
$user_names = array();
|
|
foreach ($this->getToAddresses() as $address) {
|
|
if ($address == $create_task) {
|
|
$phabricator_address = $address;
|
|
// it's okay to stop here because we just need to map a create
|
|
// address to an application and don't need / won't have more
|
|
// information in these cases.
|
|
break;
|
|
}
|
|
|
|
$matches = null;
|
|
$ok = preg_match(
|
|
$pattern,
|
|
$address,
|
|
$matches);
|
|
|
|
if ($ok) {
|
|
$phabricator_address = $address;
|
|
$receiver_name = $matches[1];
|
|
$user_id = $matches[2];
|
|
$hash = $matches[3];
|
|
break;
|
|
}
|
|
|
|
$parts = explode('@', $address);
|
|
$maybe_name = trim($parts[0]);
|
|
$maybe_domain = trim($parts[1]);
|
|
$mail_domain = PhabricatorEnv::getEnvConfig('metamta.domain');
|
|
if ($mail_domain == $maybe_domain &&
|
|
PhabricatorUser::validateUsername($maybe_name)) {
|
|
$user_names[] = $maybe_name;
|
|
}
|
|
}
|
|
|
|
// since we haven't found a phabricator address, maybe this is
|
|
// someone trying to create a conpherence?
|
|
if (!$phabricator_address && $user_names) {
|
|
$users = id(new PhabricatorUser())
|
|
->loadAllWhere('userName IN (%Ls)', $user_names);
|
|
$user_phids = mpull($users, 'getPHID');
|
|
}
|
|
|
|
return array(
|
|
$phabricator_address,
|
|
$receiver_name,
|
|
$user_id,
|
|
$hash,
|
|
$user_phids
|
|
);
|
|
}
|
|
|
|
|
|
public function processReceivedMail() {
|
|
|
|
try {
|
|
$this->dropMailFromPhabricator();
|
|
$this->dropMailAlreadyReceived();
|
|
|
|
$receiver = $this->loadReceiver();
|
|
|
|
} catch (PhabricatorMetaMTAReceivedMailProcessingException $ex) {
|
|
$this
|
|
->setStatus($ex->getStatusCode())
|
|
->setMessage($ex->getMessage())
|
|
->save();
|
|
return $this;
|
|
}
|
|
|
|
list($to,
|
|
$receiver_name,
|
|
$user_id,
|
|
$hash,
|
|
$user_phids) = $this->getPhabricatorToInformation();
|
|
if (!$to && !$user_phids) {
|
|
$raw_to = idx($this->headers, 'to');
|
|
return $this->setMessage("Unrecognized 'to' format: {$raw_to}")->save();
|
|
}
|
|
|
|
$from = idx($this->headers, 'from');
|
|
|
|
// TODO -- make this a switch statement / better if / when we add more
|
|
// public create email addresses!
|
|
$create_task = PhabricatorEnv::getEnvConfig(
|
|
'metamta.maniphest.public-create-email');
|
|
|
|
if ($create_task && $to == $create_task) {
|
|
$receiver = new ManiphestTask();
|
|
|
|
$user = $this->lookupSender();
|
|
if ($user) {
|
|
$this->setAuthorPHID($user->getPHID());
|
|
} else {
|
|
$allow_email_users = PhabricatorEnv::getEnvConfig(
|
|
'phabricator.allow-email-users');
|
|
|
|
if ($allow_email_users) {
|
|
$email = new PhutilEmailAddress($from);
|
|
|
|
$xuser = id(new PhabricatorExternalAccount())->loadOneWhere(
|
|
'accountType = %s AND accountDomain IS NULL and accountID = %s',
|
|
'email',
|
|
$email->getAddress());
|
|
|
|
if (!$xuser) {
|
|
$xuser = new PhabricatorExternalAccount();
|
|
$xuser->setAccountID($email->getAddress());
|
|
$xuser->setAccountType('email');
|
|
$xuser->setDisplayName($email->getDisplayName());
|
|
$xuser->save();
|
|
}
|
|
|
|
$user = $xuser->getPhabricatorUser();
|
|
} else {
|
|
$default_author = PhabricatorEnv::getEnvConfig(
|
|
'metamta.maniphest.default-public-author');
|
|
|
|
if ($default_author) {
|
|
$user = id(new PhabricatorUser())->loadOneWhere(
|
|
'username = %s',
|
|
$default_author);
|
|
|
|
if (!$user) {
|
|
throw new Exception(
|
|
"Phabricator is misconfigured, the configuration key ".
|
|
"'metamta.maniphest.default-public-author' is set to user ".
|
|
"'{$default_author}' but that user does not exist.");
|
|
}
|
|
|
|
} else {
|
|
// TODO: We should probably bounce these since from the user's
|
|
// perspective their email vanishes into a black hole.
|
|
return $this->setMessage("Invalid public user '{$from}'.")->save();
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
$receiver->setAuthorPHID($user->getPHID());
|
|
$receiver->setOriginalEmailSource($from);
|
|
$receiver->setPriority(ManiphestTaskPriority::PRIORITY_TRIAGE);
|
|
|
|
$editor = new ManiphestTransactionEditor();
|
|
$editor->setActor($user);
|
|
$handler = $editor->buildReplyHandler($receiver);
|
|
|
|
$handler->setActor($user);
|
|
$handler->setExcludeMailRecipientPHIDs(
|
|
$this->loadExcludeMailRecipientPHIDs());
|
|
$handler->processEmail($this);
|
|
|
|
$this->setRelatedPHID($receiver->getPHID());
|
|
$this->setMessage('OK');
|
|
|
|
return $this->save();
|
|
}
|
|
|
|
// means we're creating a conpherence...!
|
|
if ($user_phids) {
|
|
// we must have a valid user who created this conpherence
|
|
$user = $this->lookupSender();
|
|
if (!$user) {
|
|
return $this->setMessage("Invalid public user '{$from}'.")->save();
|
|
}
|
|
|
|
$conpherence = id(new ConpherenceReplyHandler())
|
|
->setMailReceiver(new ConpherenceThread())
|
|
->setMailAddedParticipantPHIDs($user_phids)
|
|
->setActor($user)
|
|
->setExcludeMailRecipientPHIDs($this->loadExcludeMailRecipientPHIDs())
|
|
->processEmail($this);
|
|
|
|
$this->setRelatedPHID($conpherence->getPHID());
|
|
$this->setMessage('OK');
|
|
return $this->save();
|
|
}
|
|
|
|
if ($user_id == 'public') {
|
|
if (!PhabricatorEnv::getEnvConfig('metamta.public-replies')) {
|
|
return $this->setMessage("Public replies not enabled.")->save();
|
|
}
|
|
|
|
$user = $this->lookupSender();
|
|
|
|
if (!$user) {
|
|
return $this->setMessage("Invalid public user '{$from}'.")->save();
|
|
}
|
|
|
|
$use_user_hash = false;
|
|
} else {
|
|
$user = id(new PhabricatorUser())->load($user_id);
|
|
if (!$user) {
|
|
return $this->setMessage("Invalid private user '{$user_id}'.")->save();
|
|
}
|
|
|
|
$use_user_hash = true;
|
|
}
|
|
|
|
if ($user->getIsDisabled()) {
|
|
return $this->setMessage("User '{$user_id}' is disabled")->save();
|
|
}
|
|
|
|
$this->setAuthorPHID($user->getPHID());
|
|
|
|
$receiver = self::loadReceiverObject($receiver_name);
|
|
if (!$receiver) {
|
|
return $this->setMessage("Invalid object '{$receiver_name}'")->save();
|
|
}
|
|
|
|
$this->setRelatedPHID($receiver->getPHID());
|
|
|
|
if ($use_user_hash) {
|
|
// This is a private reply-to address, check that the user hash is
|
|
// correct.
|
|
$check_phid = $user->getPHID();
|
|
} else {
|
|
// This is a public reply-to address, check that the object hash is
|
|
// correct.
|
|
$check_phid = $receiver->getPHID();
|
|
}
|
|
|
|
$expect_hash = self::computeMailHash($receiver->getMailKey(), $check_phid);
|
|
|
|
if ($expect_hash != $hash) {
|
|
return $this->setMessage("Invalid mail hash!")->save();
|
|
}
|
|
|
|
if ($receiver instanceof ManiphestTask) {
|
|
$editor = new ManiphestTransactionEditor();
|
|
$editor->setActor($user);
|
|
$handler = $editor->buildReplyHandler($receiver);
|
|
} else if ($receiver instanceof DifferentialRevision) {
|
|
$handler = DifferentialMail::newReplyHandlerForRevision($receiver);
|
|
} else if ($receiver instanceof PhabricatorRepositoryCommit) {
|
|
$handler = PhabricatorAuditCommentEditor::newReplyHandlerForCommit(
|
|
$receiver);
|
|
} else if ($receiver instanceof ConpherenceThread) {
|
|
$handler = id(new ConpherenceReplyHandler())
|
|
->setMailReceiver($receiver);
|
|
}
|
|
|
|
$handler->setActor($user);
|
|
$handler->setExcludeMailRecipientPHIDs(
|
|
$this->loadExcludeMailRecipientPHIDs());
|
|
$handler->processEmail($this);
|
|
|
|
$this->setMessage('OK');
|
|
|
|
return $this->save();
|
|
}
|
|
|
|
public function getCleanTextBody() {
|
|
$body = idx($this->bodies, 'text');
|
|
|
|
$parser = new PhabricatorMetaMTAEmailBodyParser();
|
|
return $parser->stripTextBody($body);
|
|
}
|
|
|
|
public function getRawTextBody() {
|
|
return idx($this->bodies, 'text');
|
|
}
|
|
|
|
public static function loadReceiverObject($receiver_name) {
|
|
if (!$receiver_name) {
|
|
return null;
|
|
}
|
|
|
|
$receiver_type = $receiver_name[0];
|
|
$receiver_id = substr($receiver_name, 1);
|
|
|
|
$class_obj = null;
|
|
switch ($receiver_type) {
|
|
case 'T':
|
|
$class_obj = new ManiphestTask();
|
|
break;
|
|
case 'D':
|
|
$class_obj = new DifferentialRevision();
|
|
break;
|
|
case 'C':
|
|
$class_obj = new PhabricatorRepositoryCommit();
|
|
break;
|
|
case 'E':
|
|
$class_obj = new ConpherenceThread();
|
|
break;
|
|
default:
|
|
return null;
|
|
}
|
|
|
|
return $class_obj->load($receiver_id);
|
|
}
|
|
|
|
public static function computeMailHash($mail_key, $phid) {
|
|
$global_mail_key = PhabricatorEnv::getEnvConfig('phabricator.mail-key');
|
|
|
|
$hash = PhabricatorHash::digest($mail_key.$global_mail_key.$phid);
|
|
return substr($hash, 0, 16);
|
|
}
|
|
|
|
/**
|
|
* Strip an email address down to the actual user@domain.tld part if
|
|
* necessary, since sometimes it will have formatting like
|
|
* '"Abraham Lincoln" <alincoln@logcab.in>'.
|
|
*/
|
|
private function getRawEmailAddress($address) {
|
|
$matches = null;
|
|
$ok = preg_match('/<(.*)>/', $address, $matches);
|
|
if ($ok) {
|
|
$address = $matches[1];
|
|
}
|
|
return $address;
|
|
}
|
|
|
|
private function getRawEmailAddresses($addresses) {
|
|
$raw_addresses = array();
|
|
foreach (explode(',', $addresses) as $address) {
|
|
$raw_addresses[] = $this->getRawEmailAddress($address);
|
|
}
|
|
return array_filter($raw_addresses);
|
|
}
|
|
|
|
private function lookupSender() {
|
|
$from = idx($this->headers, 'from');
|
|
$from = $this->getRawEmailAddress($from);
|
|
|
|
$user = PhabricatorUser::loadOneWithEmailAddress($from);
|
|
|
|
// If Phabricator is configured to allow "Reply-To" authentication, try
|
|
// the "Reply-To" address if we failed to match the "From" address.
|
|
$config_key = 'metamta.insecure-auth-with-reply-to';
|
|
$allow_reply_to = PhabricatorEnv::getEnvConfig($config_key);
|
|
|
|
if (!$user && $allow_reply_to) {
|
|
$reply_to = idx($this->headers, 'reply-to');
|
|
$reply_to = $this->getRawEmailAddress($reply_to);
|
|
if ($reply_to) {
|
|
$user = PhabricatorUser::loadOneWithEmailAddress($reply_to);
|
|
}
|
|
}
|
|
|
|
return $user;
|
|
}
|
|
|
|
/**
|
|
* If Phabricator sent the mail, always drop it immediately. This prevents
|
|
* loops where, e.g., the public bug address is also a user email address
|
|
* and creating a bug sends them an email, which loops.
|
|
*/
|
|
private function dropMailFromPhabricator() {
|
|
if (!$this->getHeader('x-phabricator-sent-this-message')) {
|
|
return;
|
|
}
|
|
|
|
throw new PhabricatorMetaMTAReceivedMailProcessingException(
|
|
MetaMTAReceivedMailStatus::STATUS_FROM_PHABRICATOR,
|
|
"Ignoring email with 'X-Phabricator-Sent-This-Message' header to avoid ".
|
|
"loops.");
|
|
}
|
|
|
|
/**
|
|
* If this mail has the same message ID as some other mail, and isn't the
|
|
* first mail we we received with that message ID, we drop it as a duplicate.
|
|
*/
|
|
private function dropMailAlreadyReceived() {
|
|
$message_id_hash = $this->getMessageIDHash();
|
|
if (!$message_id_hash) {
|
|
// No message ID hash, so we can't detect duplicates. This should only
|
|
// happen with very old messages.
|
|
return;
|
|
}
|
|
|
|
$messages = $this->loadAllWhere(
|
|
'messageIDHash = %s ORDER BY id ASC LIMIT 2',
|
|
$message_id_hash);
|
|
$messages_count = count($messages);
|
|
if ($messages_count <= 1) {
|
|
// If we only have one copy of this message, we're good to process it.
|
|
return;
|
|
}
|
|
|
|
$first_message = reset($messages);
|
|
if ($first_message->getID() == $this->getID()) {
|
|
// If this is the first copy of the message, it is okay to process it.
|
|
// We may not have been able to to process it immediately when we received
|
|
// it, and could may have received several copies without processing any
|
|
// yet.
|
|
return;
|
|
}
|
|
|
|
$message = sprintf(
|
|
'Ignoring email with message id hash "%s" that has been seen %d '.
|
|
'times, including this message.',
|
|
$message_id_hash,
|
|
$messages_count);
|
|
|
|
throw new PhabricatorMetaMTAReceivedMailProcessingException(
|
|
MetaMTAReceivedMailStatus::STATUS_DUPLICATE,
|
|
$message);
|
|
}
|
|
|
|
|
|
/**
|
|
* Load a concrete instance of the @{class:PhabricatorMailReceiver} which
|
|
* accepts this mail, if one exists.
|
|
*/
|
|
private function loadReceiver() {
|
|
$receivers = id(new PhutilSymbolLoader())
|
|
->setAncestorClass('PhabricatorMailReceiver')
|
|
->loadObjects();
|
|
|
|
$accept = array();
|
|
foreach ($receivers as $key => $receiver) {
|
|
if (!$receiver->isEnabled()) {
|
|
continue;
|
|
}
|
|
if ($receiver->canAcceptMail($this)) {
|
|
$accept[$key] = $receiver;
|
|
}
|
|
}
|
|
|
|
if (!$accept) {
|
|
throw new PhabricatorMetaMTAReceivedMailProcessingException(
|
|
MetaMTAReceivedMailStatus::STATUS_NO_RECEIVERS,
|
|
"No concrete, enabled subclasses of `PhabricatorMailReceiver` can ".
|
|
"accept this mail.");
|
|
}
|
|
|
|
if (count($accept) > 1) {
|
|
$names = implode(', ', array_keys($accept));
|
|
throw new PhabricatorMetaMTAReceivedMailProcessingException(
|
|
MetaMTAReceivedMailStatus::STATUS_ABUNDANT_RECEIVERS,
|
|
"More than one `PhabricatorMailReceiver` claims to accept this mail.");
|
|
}
|
|
|
|
return head($accept);
|
|
}
|
|
|
|
}
|