mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
a823654be0
Summary: Fixes T5646. Makes diffusion a much better user experience. Users now see a 404 exception page when they have a bad URI. Previously, they saw a developer-facing raw exception. Test Plan: played around in diffusion a bunch. most of these changes were fairly mechanical at the end of the day. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T5646 Differential Revision: https://secure.phabricator.com/D11299
152 lines
4 KiB
PHP
152 lines
4 KiB
PHP
<?php
|
|
|
|
final class DiffusionSymbolController extends DiffusionController {
|
|
|
|
private $name;
|
|
|
|
protected function processDiffusionRequest(AphrontRequest $request) {
|
|
$user = $request->getUser();
|
|
$this->name = $request->getURIData('name');
|
|
|
|
$query = new DiffusionSymbolQuery();
|
|
$query->setName($this->name);
|
|
|
|
if ($request->getStr('context') !== null) {
|
|
$query->setContext($request->getStr('context'));
|
|
}
|
|
|
|
if ($request->getStr('type')) {
|
|
$query->setType($request->getStr('type'));
|
|
}
|
|
|
|
if ($request->getStr('lang')) {
|
|
$query->setLanguage($request->getStr('lang'));
|
|
}
|
|
|
|
if ($request->getStr('projects')) {
|
|
$phids = $request->getStr('projects');
|
|
$phids = explode(',', $phids);
|
|
$phids = array_filter($phids);
|
|
|
|
if ($phids) {
|
|
$projects = id(new PhabricatorRepositoryArcanistProject())
|
|
->loadAllWhere(
|
|
'phid IN (%Ls)',
|
|
$phids);
|
|
$projects = mpull($projects, 'getID');
|
|
if ($projects) {
|
|
$query->setProjectIDs($projects);
|
|
}
|
|
}
|
|
}
|
|
|
|
$query->needPaths(true);
|
|
$query->needArcanistProjects(true);
|
|
$query->needRepositories(true);
|
|
|
|
$symbols = $query->execute();
|
|
|
|
// For PHP builtins, jump to php.net documentation.
|
|
if ($request->getBool('jump') && count($symbols) == 0) {
|
|
if ($request->getStr('lang', 'php') == 'php') {
|
|
if ($request->getStr('type', 'function') == 'function') {
|
|
$functions = get_defined_functions();
|
|
if (in_array($this->name, $functions['internal'])) {
|
|
return id(new AphrontRedirectResponse())
|
|
->setIsExternal(true)
|
|
->setURI('http://www.php.net/function.'.$this->name);
|
|
}
|
|
}
|
|
if ($request->getStr('type', 'class') == 'class') {
|
|
if (class_exists($this->name, false) ||
|
|
interface_exists($this->name, false)) {
|
|
if (id(new ReflectionClass($this->name))->isInternal()) {
|
|
return id(new AphrontRedirectResponse())
|
|
->setIsExternal(true)
|
|
->setURI('http://www.php.net/class.'.$this->name);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
$rows = array();
|
|
foreach ($symbols as $symbol) {
|
|
$project = $symbol->getArcanistProject();
|
|
if ($project) {
|
|
$project_name = $project->getName();
|
|
} else {
|
|
$project_name = '-';
|
|
}
|
|
|
|
$file = $symbol->getPath();
|
|
$line = $symbol->getLineNumber();
|
|
|
|
$repo = $symbol->getRepository();
|
|
if ($repo) {
|
|
$href = $symbol->getURI();
|
|
|
|
if ($request->getBool('jump') && count($symbols) == 1) {
|
|
// If this is a clickthrough from Differential, just jump them
|
|
// straight to the target if we got a single hit.
|
|
return id(new AphrontRedirectResponse())->setURI($href);
|
|
}
|
|
|
|
$location = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
),
|
|
$file.':'.$line);
|
|
} else if ($file) {
|
|
$location = $file.':'.$line;
|
|
} else {
|
|
$location = '?';
|
|
}
|
|
|
|
$rows[] = array(
|
|
$symbol->getSymbolType(),
|
|
$symbol->getSymbolContext(),
|
|
$symbol->getSymbolName(),
|
|
$symbol->getSymbolLanguage(),
|
|
$project_name,
|
|
$location,
|
|
);
|
|
}
|
|
|
|
$table = new AphrontTableView($rows);
|
|
$table->setHeaders(
|
|
array(
|
|
pht('Type'),
|
|
pht('Context'),
|
|
pht('Name'),
|
|
pht('Language'),
|
|
pht('Project'),
|
|
pht('File'),
|
|
));
|
|
$table->setColumnClasses(
|
|
array(
|
|
'',
|
|
'',
|
|
'pri',
|
|
'',
|
|
'',
|
|
'',
|
|
));
|
|
$table->setNoDataString(
|
|
pht('No matching symbol could be found in any indexed project.'));
|
|
|
|
$panel = new AphrontPanelView();
|
|
$panel->setHeader(pht('Similar Symbols'));
|
|
$panel->appendChild($table);
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$panel,
|
|
),
|
|
array(
|
|
'title' => pht('Find Symbol'),
|
|
));
|
|
}
|
|
|
|
}
|