1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-22 20:51:10 +01:00
phorge-phorge/webroot/rsrc/js
epriestley 35750b9c61 Make some Differential comment actions (like "Accept" and "Reject") conflict with one another
Summary:
Ref T11114. When a user selects "Accept", and then selects "Reject", remove the "Accept". It does not make sense to both accept and reject a revision.

For now, every one of the "actions" conflicts: accept, reject, resign, claim, close, commandeer, etc, etc. I couldn't come up with any combinations that it seems like users are reasonably likely to want to try, and we haven't received combo-action requests in the past that I can recall.

Test Plan:
  - Selected "Accept", then selected "Reject". One replaced the other.
  - Selected "Accept", then selected "Change Subscribers". Both co-existed happily.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17132
2017-01-02 13:25:12 -08:00
..
application Make some Differential comment actions (like "Accept" and "Reject") conflict with one another 2017-01-02 13:25:12 -08:00
core Allow any EditEngine comment form to be pinned 2016-12-29 12:49:18 -08:00
phui Remove old ObjectBox tab cruft 2016-06-30 18:50:25 -07:00
phuix Restore "Reclaim" and "Abandon" actions to Differential on EditEngine 2016-12-31 10:06:46 -08:00