1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
phorge-phorge/src/applications/diffusion
epriestley 35ccda922a Merge diffusion.commitbranchesquery into diffusion.branchquery
Summary:
Ref T4327. This is general cleanup since I was in this area of the code. Primarily, the Mercurial implementation here was completely broken and wrong:

  - It returned only one branch, but a commit can be present on many branches.
  - It did not account for multiple branch heads.
  - It returned a result implying the branch head pointed at the queried commit, which is no consistent or accurate.

Simplify the amount of API we're dealing with by collapsing this method into the very similar `diffusion.branchquery` method.

Test Plan: Looked at mercurial and git repositories and commits, branch information seemed correct.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4327

Differential Revision: https://secure.phabricator.com/D8003
2014-01-17 16:11:04 -08:00
..
application Add a Diffusion repository remarkup rule 2013-12-31 11:08:08 -08:00
capability Add global "push" policy to Repositories 2013-10-29 15:32:40 -07:00
conduit Merge diffusion.commitbranchesquery into diffusion.branchquery 2014-01-17 16:11:04 -08:00
config Specify an ssh port for Diffusion when running against the grain 2013-12-11 12:11:13 -08:00
controller Merge diffusion.commitbranchesquery into diffusion.branchquery 2014-01-17 16:11:04 -08:00
data Remove DiffusionBranchInformation in favor of DiffusionRepositoryRef 2014-01-17 16:10:56 -08:00
doorkeeper Remove loadMemberPHIDs from PhabricatorProject 2013-10-06 17:07:08 -07:00
engine Apply "enormous changes" rules to pre-commit content rules too 2014-01-06 12:12:30 -08:00
events Tie application event listeners to the applications they listen for 2013-10-21 17:00:21 -07:00
exception Reject dangerous changes in Git repositories by default 2013-12-03 10:28:39 -08:00
herald Apply "enormous changes" rules to pre-commit content rules too 2014-01-06 12:12:30 -08:00
panel Simplify PHUIObjectBoxViews handling of Save and Error states 2014-01-10 09:17:37 -08:00
protocol Fix loop in svnserve workflow for large binaries 2013-12-18 17:48:29 -08:00
query Remove DiffusionBranchInformation in favor of DiffusionRepositoryRef 2014-01-17 16:10:56 -08:00
remarkup Add a Diffusion repository remarkup rule 2013-12-31 11:08:08 -08:00
request Remove DiffusionBranchInformation in favor of DiffusionRepositoryRef 2014-01-17 16:10:56 -08:00
response Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00
ssh Store pusher remote address and push protocol in PushLog 2013-12-05 11:59:22 -08:00
view Remove DiffusionBranchInformation in favor of DiffusionRepositoryRef 2014-01-17 16:10:56 -08:00
DiffusionLintSaveRunner.php Make most repository reads policy-aware 2013-09-25 16:54:48 -07:00